Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace null values with empty strings when pulling nested keys #11

Closed
Pegase745 opened this issue Jul 14, 2020 · 1 comment
Closed

Replace null values with empty strings when pulling nested keys #11

Pegase745 opened this issue Jul 14, 2020 · 1 comment
Labels
bug Something isn't working released

Comments

@Pegase745
Copy link
Contributor

Describe the bug
The retrieved empty values of nested keys are set to null

{
  "error": {
    "generic": {
      "body": null
    }
  }
}

To Reproduce
Try a wti pull on a project that has nested keys.

Expected behavior
null values should be replaced by an empty string

{
  "error": {
    "generic": {
      "body": ""
    }
  }
}

Doing so, is compliant with i18next default behavior
@Pegase745 Pegase745 added the bug Something isn't working label Jul 14, 2020
github-actions bot pushed a commit that referenced this issue Jul 17, 2020
@semantic-release-bot
chore(release): version 1.3.1 [skip ci]
aea40eb 
## [1.3.1](v1.3.0...v1.3.1) (2020-07-17)

### Bug Fixes

* **pull:** replace null values with empty strings in nested keys ([2637354](2637354)), closes [#11](#11)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pegase745