Suppress Ruby warnings #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change suppresses following warnings (about 45 lines or more): lib/serverengine/daemon_logger.rb:61: warning: instance variable @file_dev not initialized lib/serverengine/daemon_logger.rb:63: warning: instance variable @file_dev not initialized (snip) lib/serverengine/daemon_logger.rb:56: warning: instance variable @file_dev not initialized lib/serverengine/daemon_logger.rb:121: warning: instance variable @file_dev not initialized
This change can suppresses following warnings(26 lines): lib/serverengine/config_loader.rb:43: warning: instance variable @logger not initialized
This change suppresses following warning: lib/serverengine/daemon.rb:34: warning: shadowing outer local variable - load_config_proc
This change suppresses following warning: lib/serverengine/supervisor.rb:152: warning: assigned but unused variable - stat
This change can suppress following warnings(84 lines): spec/server_worker_context.rb:48: warning: method redefined; discarding old initialize spec/server_worker_context.rb:48: warning: previous definition of initialize was here spec/server_worker_context.rb:52: warning: method redefined; discarding old before_run spec/server_worker_context.rb:52: warning: previous definition of before_run was here spec/server_worker_context.rb:56: warning: method redefined; discarding old after_run spec/server_worker_context.rb:56: warning: previous definition of after_run was here spec/server_worker_context.rb:60: warning: method redefined; discarding old after_start spec/server_worker_context.rb:60: warning: previous definition of after_start was here spec/server_worker_context.rb:64: warning: method redefined; discarding old stop spec/server_worker_context.rb:64: warning: previous definition of stop was here spec/server_worker_context.rb:74: warning: method redefined; discarding old restart spec/server_worker_context.rb:74: warning: previous definition of restart was here spec/server_worker_context.rb:84: warning: method redefined; discarding old reload spec/server_worker_context.rb:84: warning: previous definition of reload was here spec/server_worker_context.rb:89: warning: method redefined; discarding old detach spec/server_worker_context.rb:89: warning: previous definition of detach was here spec/server_worker_context.rb:96: warning: method redefined; discarding old initialize spec/server_worker_context.rb:96: warning: previous definition of initialize was here spec/server_worker_context.rb:101: warning: method redefined; discarding old before_fork spec/server_worker_context.rb:101: warning: previous definition of before_fork was here spec/server_worker_context.rb:105: warning: method redefined; discarding old run spec/server_worker_context.rb:105: warning: previous definition of run was here spec/server_worker_context.rb:115: warning: method redefined; discarding old stop spec/server_worker_context.rb:115: warning: previous definition of stop was here spec/server_worker_context.rb:120: warning: method redefined; discarding old reload spec/server_worker_context.rb:120: warning: previous definition of reload was here spec/server_worker_context.rb:124: warning: method redefined; discarding old after_start spec/server_worker_context.rb:124: warning: previous definition of after_start was here
This change suppresses following warnings: spec/signal_thread_spec.rb:42: warning: assigned but unused variable - t spec/signal_thread_spec.rb:58: warning: assigned but unused variable - n spec/signal_thread_spec.rb:83: warning: shadowing outer local variable - t spec/signal_thread_spec.rb:73: warning: assigned but unused variable - t
This change suppresses following warnings: spec/socket_manager_spec.rb:40: warning: assigned but unused variable - from spec/socket_manager_spec.rb:92: warning: assigned but unused variable - from
This change suppresses following warnings: spec/socket_manager_spec.rb:10: warning: File.exists? is a deprecated name, use File.exist? instead spec/socket_manager_spec.rb:10: warning: File.exists? is a deprecated name, use File.exist? instead
|
Many warnings (93lines) are remained. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fluentd uses ServerEngine on Fluentd master branch.
I've worked to eliminate warning messages that is
reported when running Fluentd's test.
Some warning messages are reported from ServerEngine's code
when I execute Fluentd's test.