Fix SVG styles conflict (example) #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voltidev
commented
May 6, 2018
package.json
Outdated
| @@ -80,7 +80,7 @@ | |||
| "ember-route-action-helper": "^2.0.3", | |||
| "ember-sinon": "^1.0.1", | |||
| "ember-source": "^2.18.2", | |||
| "ember-svg-jar": "^1.1.1", | |||
| "ember-svg-jar": "ivanvotti/ember-svg-jar#custom-svgo-module", | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
voltidev
commented
May 6, 2018
| inlineStyles: { | ||
| onlyMatchedOnce: false, | ||
| removeMatchedSelectors: true | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
voltidev
commented
May 6, 2018
| }, | ||
| svgJar: { | ||
| optimizer: { | ||
| svgoModule: SVGO, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Thank you! This is really above-and-beyond in terms of responding to my issue. I have some significant work happening elsewhere in this repository that I need to get to, but I’ll keep this around so we can move to using the |
# Conflicts: # package-lock.json # package.json
backspace
added a commit
that referenced
this pull request
May 30, 2018
#1645 will be better for this but I’m waiting for Percy to be back 😆
backspace
added a commit
that referenced
this pull request
May 30, 2018
The issue I discussed here is affecting the footer logo: evoactivity/ember-svg-jar#68 While #1645 will be a better solution, I’m not ready to merge it.
# Conflicts: # package-lock.json
There’s some rendering weirdness that I can’t spend any more time trying to figure out. This will do!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an example of how the problem can be fixed with SVGO. The new SVGO version has slightly changed plugin defaults, so I had to add
{ removeViewBox: false }to prevent viewBox deletion.