Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember and family to 2.18 #1484

Merged
merged 17 commits into from
Jan 23, 2018
Merged

Update Ember and family to 2.18 #1484

merged 17 commits into from
Jan 23, 2018

Conversation

backspace
Copy link
Contributor

This is a first pass after a complex merge. I expect many
lint failures and deprecations.

I wonder whether we can just import the Airbnb ESLint config
rather than duplicating it?

@backspace
Copy link
Contributor Author

There are two duplicate deprecation warnings when running the server:

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:   NPMDependencyVersionChecker (/Users/b/Documents/Travis/travis-web/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:32)
DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:   NPMDependencyVersionChecker (/Users/b/Documents/Travis/travis-web/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:32)

From what I can tell, these come from addons that have an old version of ember-cli-version-checker. I updated the addons I could… meh

I haven’t looked at deprecations in the console yet.

@backspace
Copy link
Contributor Author

This seems sufficient; I’ll merge and deploy tomorrow.

@drogus
Copy link
Contributor

drogus commented Jan 23, 2018

I'm super happy to see this, because I'd like us to try out 2 new things: Glimmer named arguments and ES5 getters

@backspace backspace merged commit 8200ce8 into master Jan 23, 2018
@backspace backspace deleted the bd-ember-2.18 branch February 12, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants