Add env variables to improve jvm performance and memory allocation #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdanap
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure you cover the following points:
What is the problem that this PR is trying to fix?
https://github.com/travis-pro/team-blue/issues/728
and more specifically: https://github.com/travis-pro/team-blue/issues/728#issuecomment-322746660
What approach did you choose and why?
Add env variables to optimize jvm's memory usage, as suggested in the comment above.
I thought the travis_java cookbook is a good place for this since it's less generic and it is included in all images we're building (including connie, which was the main one our users were complaining about):
cookbooks/travis_ci_amethyst/recipes/default.rb:include_recipe 'travis_java' cookbooks/travis_ci_connie/recipes/default.rb:include_recipe 'travis_java' cookbooks/travis_ci_cookiecat/recipes/default.rb:include_recipe 'travis_java' cookbooks/travis_ci_garnet/recipes/default.rb:include_recipe 'travis_java' cookbooks/travis_ci_stevonnie/recipes/default.rb:include_recipe 'travis_java' cookbooks/travis_ci_sugilite/recipes/default.rb:include_recipe 'travis_java'How can you test this?
Build the images and check the presence of the new variables in a debug build.
Run a previously failing build on connie and see that it passes (Example: https://travis-ci.org/comdata/HomeAutomation/builds/255176816)
What feedback would you like?
Is travis_java the best place for these changes?
We also configure this as part of travis_sbt_extras - should this be removed now?