-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enterprise to master. #1316
base: master
Are you sure you want to change the base?
Enterprise to master. #1316
Conversation
Co-authored-by: gabriel-arc <[email protected]>
* repo settings merge from master
* Rspec are loading & some deprecation fixes * some Arel and handling string as hash * No more composite keys * fixing deprecations for rake - parsing json * fixing deprecations * further cleanup * Some fixex including repo - but logic must be discussed * cleanup with composite keys * Revert "cleanup with composite keys" This reverts commit c9c7960. * Revert "No more composite keys" This reverts commit 8fb395e. * further changes and fixes * More spohisticated changes * ruby, ar upgrade && annoying bug fix for composite keys * Cleanup after not proper fixes * sentry & openssl upgrade * add root to serialized json * Proper gems are used * USing old Metrics * Next fixes * almost there * All green * Further gems update * problems with simple states * removing s3 step 1 * moving s3 to fog * s3 totally removed * some Gemfile changes * docker fix * sidekiq update * better regexp * Nicely usage of Mustermann * guard for AR patch * clear active connections * nokogiri bump * Parse config if string * Ensure Hash is saved into Json settings/preferences * next approach to make settings an actual hash * Ensure settings/preferences are hash Co-authored-by: Maciej <[email protected]> Co-authored-by: gabriel-arc <[email protected]>
* github_apps update * activerecord bump to 6.1.6.1 * permit symbol in yaml deserializer for debug
* BSFY-141 merge - add restarted by
* bundler update * merge from master 31.10.22 * usr/group update * ship:docker
* Add tag_name to build request * Restrict ruby gem-update version --------- Co-authored-by: piccadilly-circus <[email protected]>
Gemfile
Outdated
gem 'travis-lock', git: 'https://github.com/travis-ci/travis-lock' | ||
gem 'travis-github_apps', git: 'https://github.com/travis-ci/travis-github_apps' | ||
gem 'travis-settings', git: 'https://github.com/travis-ci/travis-settings', branch: 'master' | ||
gem 'travis-lock', git: 'https://github.com/travis-ci/travis-lock/', branch: '6.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master, latest updates are already merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Gemfile
Outdated
gem 'travis-rollout', git: 'https://github.com/travis-ci/travis-rollout' | ||
gem 'simple_states', git: 'https://github.com/travis-ci/simple_states', branch: 'prd-ruby-upgrade-dev' | ||
gem 'metriks', git: 'https://github.com/travis-ci/metriks' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
Gemfile
Outdated
gem 'marginalia', git: 'https://github.com/travis-ci/marginalia' | ||
gem 'gh', git: 'https://github.com/travis-ci/gh' | ||
gem 'rollout', git: 'https://github.com/travis-ci/rollout' | ||
|
||
gem 'mustermann' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
Gemfile
Outdated
gem 'rack-cache', git: 'https://github.com/rtomayko/rack-cache' | ||
gem 'rack-attack', '~> 6' | ||
gem 'bunny', '~> 2.22' | ||
gem 'dalli' | ||
gem 'pry' | ||
gem 'http', '~> 4' | ||
gem 'metriks', '0.9.9.6' | ||
gem 'metriks-librato_metrics', git: 'https://github.com/eric/metriks-librato_metrics' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep the ones from master(metriks/metriks-librato_metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Gemfile
Outdated
gem 'stackprof' | ||
gem "ipaddress", "~> 0.8.3" | ||
gem 'nakayoshi_fork' | ||
gem 'sidekiq' | ||
gem 'sidekiq', '~> 6.4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't pin the version to 6, current is 7.x
@@ -14,7 +14,9 @@ | |||
WebMock.stub_request(:get, "http://vcsfake.travis-ci.com/repos/#{repo.id}/keys?user_id=#{owner.id}") | |||
.to_return( | |||
status: 200, | |||
body: JSON.dump(keys) | |||
body: JSON.dump( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afair its gem version related, keep master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
spec/support/billing_spec_helper.rb
Outdated
@@ -211,6 +211,173 @@ def billing_addon_usage_response_body(attributes = {}) | |||
}.deep_merge(attributes) | |||
end | |||
|
|||
def billing_v2_subscription_response_body(attributes={}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if billing related and not on master - don't merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated. Solved
spec/support/s3.rb
Outdated
@key = key | ||
@size = options[:size] || "0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s3 related updates on master, keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -34,11 +34,11 @@ def list_objects(params = {}) | |||
FakeBucket.new(@contents.select { |o| o.key.start_with? prefix }) | |||
end | |||
|
|||
def add(key, options = {}) | |||
contents << FakeObject.new(key, options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep master for the whole file
spec/v3/billing_client_spec.rb
Outdated
@@ -306,6 +306,18 @@ | |||
end | |||
end | |||
|
|||
describe '#pay_v2' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
billing - out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
lib/travis/api/v3/billing_client.rb
Outdated
@@ -96,12 +96,6 @@ def get_invoices_for_subscription(id) | |||
end | |||
end | |||
|
|||
def get_invoices_for_v2_subscription(id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
lib/travis/api/v3/queries/jobs.rb
Outdated
puts "USING LW JOBS!!\n\n" | ||
jobs = V3::Models::Job.where("jobs.id in (select id from most_recent_job_ids_for_user_repositories_by_states_lw(#{user.id}, ?))", states) | ||
else | ||
puts "USING REGULAR JOBS!!!\n\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls remove these three puts - this was tcie debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
lib/travis/config/defaults.rb
Outdated
database: { adapter: 'postgresql', database: "travis_#{Travis.env}", encoding: 'unicode', min_messages: 'warning', variables: { statement_timeout: 10_000 } }, | ||
db: { max_statement_timeout_in_seconds: 15, slow_host_max_statement_timeout_in_seconds: 60}, | ||
database: { adapter: 'postgresql', database: "travis_#{Travis.env}", encoding: 'unicode', min_messages: 'warning', variables: { statement_timeout: ENV['TRAVIS_DB_STATEMENT_TIMEOUT'] || 10000 } }, | ||
db: { max_statement_timeout_in_seconds: 15, slow_host_max_statement_timeout_in_seconds: ENV['TRAVIS_MAX_DB_STATEMENT_TIMEOUT'] || 15}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change default to 60 like it was before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
lib/travis/model/repository.rb
Outdated
else | ||
super(value.to_json) | ||
end | ||
value = value.is_a?(String) ? JSON.parse(value) : value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep the one from master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
spec/support/billing_spec_helper.rb
Outdated
@@ -211,6 +211,61 @@ def billing_addon_usage_response_body(attributes = {}) | |||
}.deep_merge(attributes) | |||
end | |||
|
|||
def billing_addons_response_body |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
No description provided.