Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cbreit/windows 2019 #696

Open
wants to merge 3 commits into
base: joshk/windows-2019
Choose a base branch
from
Open

Cbreit/windows 2019 #696

wants to merge 3 commits into from

Conversation

cbreit
Copy link

@cbreit cbreit commented Jun 12, 2019

What is the problem that this PR is trying to fix?

  • Improving Windows support on Travis CI.

What approach did you choose and why?

  • Additional PS-scripts to tune VM (cleanup scripts, disable certain functionality like auto updates, ...)
  • Additional common used packages on Windows (like sysinternals package)
  • Upgrade to VS2019 instead of VS2017 + remove of vcredist2017 (vcredist140 included in visualstudio2017buildtools)

How can you test this?

  • Build it on GCE

@cbreit cbreit requested a review from joshk June 12, 2019 12:52
@joshk
Copy link
Contributor

joshk commented Jun 12, 2019

This is amazing!

I was thinking, it might be good to create a dir in packer-assets called windows-2019-for-containers and add all the scripts to there?

Thoughts?

@weekly-digest weekly-digest bot mentioned this pull request Jun 16, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshk joshk Awaiting requested review from joshk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbreit @joshk