Update versions, show a matrix with multiple allow_failures #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be consistent with quotes. `allow_failures` is very useful so it is good to demonstrate it. Python 2.6 and 3.2 are EOL and 3.3 will be in just a few weeks so we should not emphasize them too much. * https://docs.python.org/devguide/index.html#branchstatus
|
Should we indicate that Should we show |
BanzaiMan
reviewed
Sep 9, 2017
user/languages/python.md
Outdated
| - "3.6-dev" # 3.6 development branch | ||
| - "3.7-dev" # 3.7 development branch | ||
| - "nightly" | ||
| - 2.6 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
BanzaiMan
reviewed
Sep 9, 2017
user/languages/python.md
Outdated
| - "pypy" # PyPy2 2.5.0 | ||
| - "pypy3" # Pypy3 2.4.0 | ||
| - "pypy-5.3.1" | ||
| - pypy # PyPy2 5.8.0 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
BanzaiMan
reviewed
Sep 9, 2017
user/languages/python.md
Outdated
| @@ -199,6 +198,21 @@ For a real world example, see [getsentry/sentry](https://github.com/getsentry/se | |||
| For Python projects, `env` and `python` can be given as arrays | |||
| to construct a build matrix. | |||
|
|
|||
| ```yaml | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The reason that I added allow_failures was because this is a year of porting in the Python world with the upcoming EOL of Python 2, the performance improvements of Python 3, and the Django 1 to 2 transition. More people could be using CI to smoothly navigate these transitions if they understood the allow_failures approach so we should not hide it. Let me know if you need it removed.
|
Also related to #1540 quote issue. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be consistent with quotes.
allow_failuresis very useful so it is good to demonstrate it.Python 2.6 and 3.2 are EOL and 3.3 will be in just a few weeks so we should not emphasize them too much.