Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Commit

Permalink
fix(dependencies): upgraded to the v17 beta of octokit
Browse files Browse the repository at this point in the history
for octokit/rest.js#1546
  • Loading branch information
travi committed Feb 9, 2020
1 parent be828b9 commit 3111a7c
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 68 deletions.
87 changes: 37 additions & 50 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
},
"dependencies": {
"@form8ion/overridable-prompts": "^1.0.0",
"@octokit/rest": "^16.43.1",
"@octokit/rest": "^17.0.0-beta.3",

This comment has been minimized.

Copy link
@travi

travi Feb 9, 2020

Author Owner

fyi @gr2m. not much surface area coverage in this package, but i'll keep you informed if i run into anything odd

This comment has been minimized.

Copy link
@gr2m

gr2m Feb 9, 2020

wonderful, thank you!

"@travi/cli-messages": "1.0.2",
"git-config": "0.0.7",
"netrc": "^0.1.4",
Expand Down
18 changes: 1 addition & 17 deletions test/integration/features/step_definitions/common-steps.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {resolve} from 'path';
import {promises, promises as fsPromises} from 'fs';
import {promises as fsPromises} from 'fs';
import {After, Before, When} from 'cucumber';
import stubbedFs from 'mock-fs';
import any from '@travi/any';
Expand All @@ -9,18 +9,6 @@ const {readFile} = fsPromises;
const pathToNodeModules = [__dirname, '../../../../', 'node_modules/'];
const debug = require('debug')('test');

function loadOctokitFiles(octokitFiles) {
return octokitFiles
.map(file => promises.readFile(resolve(...pathToNodeModules, 'octokit-pagination-methods/lib/', file)));
}

function buildOctokitFileMap(octokitFiles) {
return (acc, fileContents, index) => ({
...acc,
[octokitFiles[index]]: fileContents
});
}

Before(function () {
this.projectName = any.word();
this.projectDescription = any.sentence();
Expand All @@ -33,14 +21,10 @@ After(function () {
});

When('the project is scaffolded', async function () {
const octokitFiles = await promises.readdir(resolve(...pathToNodeModules, 'octokit-pagination-methods/lib/'));
stubbedFs({
...this.netrcContent && {[`${process.env.HOME}/.netrc`]: this.netrcContent},
[`${process.env.HOME}/.gitconfig`]: `[github]\n\tuser = ${this.githubUser}`,
node_modules: {
'octokit-pagination-methods': {
lib: (await Promise.all(loadOctokitFiles(octokitFiles))).reduce(buildOctokitFileMap(octokitFiles), {})
},
'@travi': {
'cli-messages': {
node_modules: {
Expand Down

0 comments on commit 3111a7c

Please sign in to comment.