add many_to_one proto request #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
README should also mention many-to-one, right now it's one-to-many |
Donatas-L
reviewed
Sep 5, 2023
| @@ -547,22 +547,39 @@ def create_proto_request( | |||
| destinations: List[Coordinates], | |||
| transportation: ProtoTransportation, | |||
| travel_time: int, | |||
| one_to_many: bool = True, | |||
There was a problem hiding this comment.
enum would be better it's either: one-to-many or many-to-one
danielnaumau
force-pushed
the
add/many-to-one
branch
from
7d30b16 to
8728b27
Compare
added 3 commits
September 8, 2023 09:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.