Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernizing setup #125

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Modernizing setup #125

merged 7 commits into from
Jul 16, 2024

Conversation

arnasbr
Copy link
Contributor

@arnasbr arnasbr commented Jul 15, 2024

Modernizing setup to use pyproject.toml with setuptools as backend.

Replacing python setup.py sdist bdist_wheel command with python -m build

@arnasbr arnasbr self-assigned this Jul 15, 2024
@arnasbr arnasbr mentioned this pull request Jul 15, 2024
Closed
@arnasbr arnasbr linked an issue Jul 15, 2024 that may be closed by this pull request
Migrate from setuptools to pyproject #124
Closed
@arnasbr
Copy link
Contributor Author

arnasbr commented Jul 15, 2024

I suppose the only way to test this for me is to just make a release and hope for the best. Locally building worked fine for me

@arnasbr arnasbr marked this pull request as draft July 16, 2024 08:36
@arnasbr arnasbr marked this pull request as ready for review July 16, 2024 09:29
@arnasbr arnasbr merged commit c378ce0 into master Jul 16, 2024
5 checks passed
@arnasbr arnasbr deleted the add-pyproject branch July 16, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawel-wroniszewski pawel-wroniszewski pawel-wroniszewski approved these changes

Assignees

@arnasbr arnasbr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from setuptools to pyproject
2 participants
@arnasbr @pawel-wroniszewski