Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Based on 3GPP TS 29.060 version 7.6.0 Release 7 #33

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Based on 3GPP TS 29.060 version 7.6.0 Release 7 #33

merged 1 commit into from
Feb 15, 2022

Conversation

jbdamiano
Copy link
Contributor

Section 7.7.49
the Apn restriction has a value from 0 to 3

7.7.49 APN Restriction
The APN Restriction information element, when used in messages from the GGSN to the SGSN, contains an unsigned
integer value indicating the level of restriction imposed on primary PDP Contexts created to the associated APN. When
used in messages from the SGSN to GGSN, it contains an unsigned integer value indicating the highest level of
ETSI restriction type for all currently active PDP Contexts associated with the subscriber. In both cases, the meaning of the
value contained within the IE is as defined in 3GPP TS 23.060 [4], sub-clause 15.4.
The structure of the APN Restriction IE is as follows:
Bits
Octets 1 Type = 149 (Decimal)
Octets 2-3 Length
Octets 4 Restriction Type value

@jbdamiano jbdamiano requested a review from a team as a code owner February 15, 2022 08:41
Comment on lines 1647 to 1650
decode_v1_element(<<M_restriction_type_value:8/integer,
_/binary>>, 149, Instance) ->
#apn_restriction{instance = Instance,
restriction_type_value = M_restriction_type_value};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That part of the code is auto generated by priv/ie_gen_v1.erl. You have to adjust the declaration there and regenerate the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the file and regenerated the code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please also adjust the IE test in test/property_test/gtplib_prop.erl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

===> Running Common Test suites...
%%% gtp_SUITE: ...........
All 11 tests passed.

Section 7.7.49
the Apn restriction has a value from 0 to 3
@RoadRunnr RoadRunnr merged commit a575ecd into travelping:master Feb 15, 2022
@jbdamiano jbdamiano deleted the apn_restriction_v1 branch February 15, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants