fix GTPv2 flags #11
Merged
fix GTPv2 flags #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This meant that multiple instances of fixed length IEs where not decoded with the proper instance id.
Not decoding them makes the property test fail.
proper generates a random value for integers. That does not guarantee that the full range of the integer value is tested. Include Min and Max explicitly to ensure the full range is covered.
GTPv1 does not have instance ids in the protocol. We derive them while decoding from the IE ordering. To archive a symetric en/decoding they have to be sequential, starting with 0. Change the IE generation for GTPv1 and GTPprime to archive that.
Also, change the property test to always generate flags in definition order. This makes comparing results from an encode-decode cycle simpler.
The test did first encode a message to binary and them check whether and dec+enc on that binary returned the same binary. If the initial encode already lost infromation (e.g. due to too small data type) the dec+enc check would not catch that. Instead compare the result of an enc+dec test to the original message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixup the property test to be more comprehensive