Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebar.config: Fix deps syntax #7

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

rebar.config: Fix deps syntax #7

wants to merge 7 commits into from

Conversation

pespin
Copy link

@pespin pespin commented Oct 26, 2023

  • Fix git:// protocol not available anymore on github.
  • Fix following warning from rebar3: "WARNING: It is recommended to use {branch, Name}, {tag, Tag} or {ref, Ref}, otherwise updating the dep may not work as expected."

pespin added 2 commits October 26, 2023 16:07
@pespin
rebar.config: Fix deps syntax
92b36d3 
* Fix git:// protocol not available anymore on github.
* Fix following warning from rebar3:
"WARNING: It is recommended to use {branch, Name}, {tag, Tag} or {ref, Ref},
otherwise updating the dep may not work as expected."
@pespin
rebar.config: Use latest upstream tag release for lager dep
74a3f44 
It also fixes a compile error during build with OTP-26:
"""
===> Compiling src/netlink_queue.erl failed
src/netlink_queue.erl:none: error in parse transform 'lager_transform':
exception error: bad argument
  in function  integer_to_list/1
     called as integer_to_list({80,6})
     *** argument 1: not an integer
  in call from lager_transform:make_varname/2 (/gen_netlink/_build/default/lib/lager/src/lager_transform.erl, line 241)
  in call from lager_transform:do_transform/5 (/gen_netlink/_build/default/lib/lager/src/lager_transform.erl, line 180)
  in call from lager_transform:'-transform_statement/2-lc$^0/1-0-'/2 (/gen_netlink/_build/default/lib/lager/src/lager_transform.erl, line 109)
  in call from lager_transform:'-transform_statement/2-lc$^0/1-0-'/2 (/gen_netlink/_build/default/lib/lager/src/lager_transform.erl, line 109)
  in call from lager_transform:transform_statement/2 (/gen_netlink/_build/default/lib/lager/src/lager_transform.erl, line 107)
  in call from lager_transform:'-transform_statement/2-lc$^0/1-0-'/2 (/gen_netlink/_build/default/lib/lager/src/lager_transform.erl, line 109)
  in call from lager_transform:'-transform_statement/2-lc$^0/1-0-'/2 (/gen_netlink/_build/default/lib/lager/src/lager_transform.erl, line 109)
"""
pespin added 5 commits November 3, 2023 13:00
@pespin
netlink.erl: Fix is_rt_dump
2f7262f 
https://kernel.org/doc/html/next/userspace-api/netlink/intro.html:
"""
For GET - NLM_F_ROOT and NLM_F_MATCH are combined into NLM_F_DUMP,
and not used separately. NLM_F_ATOMIC is never used.
"""

This fixes nl_rt_dec() incorrectly entering the is_rt_dump() path when
a response for create interface is received, because it has NLM_F_ROOT
set but not NLM_F_MATCH, and hence before this patch it would make
is_rtp_dump() incorrectly return true.
@pespin
netlink: Fix error code not being decoded as signed integer
cae46dd
@pespin
Support enc/dec of gtp role field
c49c8bb
@pespin
NOT_FOR_UPSTREAM: Point deps to forked repos
0de39ae
@pespin
WIP
b58c62d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pespin