Make server status metrics optional #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkatsuba
reviewed
Jul 27, 2021
vkatsuba
reviewed
Jul 27, 2021
0xAX
force-pushed
the
fix-radius-server-metrics-initialization
branch
from
8b4c9db
to
322dc19
Compare
|
Could you please also add description and examples how and what for need enable this new metrics? |
0xAX
force-pushed
the
fix-radius-server-metrics-initialization
branch
from
322dc19
to
3f823e0
Compare
vkatsuba
reviewed
Jul 28, 2021
README.md
Outdated
| @@ -232,6 +232,8 @@ Example of full configuration with keys which can use in `eradius`: | |||
| {{127, 0, 0, 3}, 1812, <<"secret">>} | |||
| ]} | |||
| ]}, | |||
| {server_status_metrics_enabled, false}, | |||
| {counter_aggregator, false},, | |||
This commits adds new configuration option - `server_status_metrics_enabled` to enable new RADIUS server status metrics. This was done to avoid situation when eradius is used without prometheus library so creation/usage of this metric will not be crashed at startup of eradius application. The default value of the new configuration option is set to `false` to preserve backward compatibility.
0xAX
force-pushed
the
fix-radius-server-metrics-initialization
branch
from
3f823e0
to
dfb668c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds new configuration option -
server_status_metrics_enabledtoenable new RADIUS server status metrics.
This was done to avoid situation when eradius is used without prometheus library
so creation/usage of this metric will not be crashed at startup of eradius
application.
The default value of the new configuration option is set to
falseto preservebackward compatibility.