Use ets:update_counter to update RADIUS metrics #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkatsuba
approved these changes
Mar 23, 2021
Previously we used two operations to update a RADIUS counter metric: ets:lookup/2 and ets:insert/2. This commit replaces these operations with one - ets:update_counter/4 which should be more efficient.
0xAX
force-pushed
the
update-counter-instead-of-lookup-and-insert
branch
from
49f4437
to
b508729
Compare
0xAX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used two operations to update a RADIUS counter metric:
ets:lookup/2 and ets:insert/2. This commit replaces these operations
with one - ets:update_counter/4 which should be more efficient.