Enable early jdk8 test (open-telemetry#11777)

trask · Jul 9, 2024 · ff5bf5d · ff5bf5d
1 parent 2cb97fc
commit ff5bf5d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/.github/workflows/publish-smoke-test-early-jdk8-images.yml b/.github/workflows/publish-smoke-test-early-jdk8-images.yml
@@ -46,8 +46,4 @@ jobs:
     if: always()
     uses: ./.github/workflows/reusable-workflow-notification.yml
     with:
-      success: >-
-        ${{
-          needs.publishLinux.result == 'success' &&
-          needs.publishWindows.result == 'success'
-        }}
+      success: ${{ needs.publish.result == 'success' }}
diff --git a/smoke-tests/src/test/groovy/io/opentelemetry/smoketest/CrashEarlyJdk8Test.groovy b/smoke-tests/src/test/groovy/io/opentelemetry/smoketest/CrashEarlyJdk8Test.groovy
@@ -13,7 +13,6 @@ import org.testcontainers.containers.output.Slf4jLogConsumer
 import org.testcontainers.containers.wait.strategy.Wait
 import org.testcontainers.utility.DockerImageName
 import org.testcontainers.utility.MountableFile
-import spock.lang.Ignore
 import spock.lang.IgnoreIf
 import spock.lang.Specification
 
@@ -25,12 +24,6 @@ import static io.opentelemetry.smoketest.TestContainerManager.useWindowsContaine
 // java.lang.invoke.CallSite
 // This test verifies that such jvm does not crash with opentelemetry agent
 @IgnoreIf({ useWindowsContainers() })
-// com.github.dockerjava.api.exception.DockerClientException: Could not pull image: [DEPRECATION NOTICE]
-// Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default
-// and will be removed in an upcoming release. Suggest the author of docker.io/azul/zulu-openjdk:8u31
-// to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information
-// at https://docs.docker.com/go/deprecated-image-specs/
-@Ignore
 class CrashEarlyJdk8Test extends Specification {
   private static final Logger logger = LoggerFactory.getLogger(CrashEarlyJdk8Test)
 
@@ -40,7 +33,7 @@ class CrashEarlyJdk8Test extends Specification {
   def "test crash on early jdk8"() {
     setup:
     GenericContainer target =
-      new GenericContainer<>(DockerImageName.parse("azul/zulu-openjdk:8u31"))
+      new GenericContainer<>(DockerImageName.parse("ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-zulu-openjdk-8u31:20240709.9848833570"))
         .withStartupTimeout(Duration.ofMinutes(5))
         .withLogConsumer(new Slf4jLogConsumer(logger))
         .withCopyFileToContainer(