Add simple cloudbuild config #4
Conversation
|
CodeQL error is "error, no code to QL" |
cloudbuild.yaml
Outdated
| args: ["golangci-lint","run"] | ||
|
|
||
| - id: 'unit tests' | ||
| name: 'golang:1.20' |
There was a problem hiding this comment.
Any reason for 1.20 here? The go.mod is 1.19 so I'd be tempted to sync them?
There was a problem hiding this comment.
Sure, 0.01 less golang done!
|
hmm, the lint wants there to be a go module to check... perhaps we should check in an "empty"/minimal module? |
|
I'll just check in the code I have I guess. I've tested it locally. Seems easier than other messing about. |
cloudbuild.yaml
Outdated
|
|
||
| steps: | ||
| - id: 'lint' | ||
| name: "golangci/golangci-lint" |
There was a problem hiding this comment.
Will this just run whatever is the latest version? We will want something hermetic or incoming PRs will be blocked on fixing up incidental changes because the ruleset has changed.
There was a problem hiding this comment.
Pinned to 1.51.
Broadly agree about random drive-by blockings, but I think it is helpful to be aware of when the codebase needs bringing into line with latest best practices (and it was certainly useful that we got the returned-errors-being-ignored warning here), but perhaps there's a better path for that which won't randomly ding PRs.
Sadly dependabot doesn't currently support updating build steps in GCB.
There was a problem hiding this comment.
I'm totally supportive of following the latest version, but it should be done with a config file checked into the repo. Shame that dependabot has a blind spot here.
|
Rebase and give this another go? |
No description provided.