Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(forge): fix failing workflow #387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sambacha
Copy link
Contributor

@sambacha sambacha commented Sep 3, 2023

The previous commit saw a CI failure due to not having --tolerance specified. I took the difference and rounded up (~2.64% difference in gas snapshot to the value of 3).

Also updated the foundry tool chain to the appropriate repo, and updated checkout to use v3.

Description

Describe the changes made in your pull request here.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge snapshot?
  • Ran npm run lint?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

The previous commit saw a CI failure due to not having `--tolerance` specified. I took the difference and rounded up (~2.64% difference in gas snapshot to the value of 3). 

Also updated the foundry tool chain to the appropriate repo, and updated checkout to use v3.
@transmissions11
Copy link
Owner

thanks! but what happened to having a deterministic seed?

@sambacha
Copy link
Contributor Author

sambacha commented Sep 5, 2023

thanks! but what happened to having a deterministic seed?

You want to create a secondary check with tolerance if the original check fails then?

@transmissions11
Copy link
Owner

hm? forge used to use a deterministic random seed such that re-running would always give the same result and we wouldn't need tolerance at all

@sambacha
Copy link
Contributor Author

hm? forge used to use a deterministic random seed such that re-running would always give the same result and we wouldn't need tolerance at all

https://book.getfoundry.sh/reference/config/testing?highlight=seed#seed

  • Type: string (hexadecimal)
  • Default: none
  • Environment: FOUNDRY_FUZZ_SEED

Optional seed for the fuzzing RNG algorithm.

I think this changed with the revm switchover, not sure tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants