✅ Fix test to fail from old deadline not arithmetic underflow #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyskylark
changed the title
|
ah nice great find. |
transmissions11
changed the title
transmissions11
changed the title
|
can you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
ERC20.t.solit appears the testtestFailPermitPastDeadlineis failing due to an underflow error from subtractingblock.timestampof 0 by 1. The test fails successfully, but not from the expired deadline of the permit.To fix the issue, I set the timestamp in the signature and the permit input to the original block.timestamp of 0. Then I used
hevm.warpto increment the currentblock.timestampby 1.Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?npm run lint?forge test?