Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testSafeTransferFrom to same address #303

Conversation

MathisGD
Copy link

@MathisGD MathisGD commented Aug 6, 2022

Description

Fixes #302 by changing the assert if from == to.

An other way to fix it would have been to assume that the address to is different than the address from, but it is better like this IMO because it also test the transfer to the same address.

Side note: All fuzzing tests has been added to the snapshot, because of this update in foundry.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge snapshot?
  • Ran npm run lint?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@MathisGD MathisGD changed the title fix: testSafeTransferFrom to same address (#302) fix: testSafeTransferFrom to same address Aug 6, 2022
@MathisGD MathisGD closed this Aug 13, 2023
@MathisGD MathisGD deleted the test/fix-testSafeTransferFromToEOA branch March 8, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testSafeTransferFrom (ERC1155) fuzzing test is failing
1 participant