Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷‍♂️ Use new foundry.toml format #289

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

onbjerg
Copy link
Contributor

@onbjerg onbjerg commented Jul 14, 2022

Description

Profiles now live under [profile.<name>]

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge snapshot?
  • Ran npm run lint?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@refcell
Copy link
Contributor

refcell commented Jul 15, 2022

Everyday check pr 289. no merge. every day. when will @transmissions11 fix warnings. My ci is breaking. Can devs DO SOMETHING??

Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update: devs did something

EDIT: i am not a maintainer

@transmissions11
Copy link
Owner

im so sorry guys i literally dont have access to the solmate repo anymore— doing what i can to resolve this offline

@PaulRBerg
Copy link
Contributor

FYI, this is the commit that introduced this breaking change in Forge:

foundry-rs/foundry@44b861b

@transmissions11 transmissions11 changed the title chore: use new foundry.toml format 👷‍♂️ Use new foundry.toml format Jul 18, 2022
@transmissions11 transmissions11 merged commit ebd7418 into transmissions11:main Jul 18, 2022
@onbjerg onbjerg deleted the onbjerg/foundry-conf branch July 19, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants