Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Fix function names in WETH tests #246

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

jaglinux
Copy link
Contributor

@jaglinux jaglinux commented May 20, 2022

Description

Deposit and fallback test names are swapped, this PR changes the name of the functions to indicate
the right test case name.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge snapshot?
  • Ran npm run lint?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@jaglinux
Copy link
Contributor Author

@transmissions11 can you review ?

@transmissions11
Copy link
Owner

lgtm ty!

@transmissions11 transmissions11 changed the title [WETH test] correct function names for deposit and fallback tests ✅ Fix function names in WETH tests Jun 22, 2022
@transmissions11 transmissions11 merged commit 3c73813 into transmissions11:main Jun 22, 2022
@jaglinux jaglinux deleted the weth_t_rename_funcs branch June 22, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants