♻️ ERC721: memory -> calldata

transmissions11 · Apr 9, 2022 · dc2b30b · dc2b30b
1 parent 5d56a1f
commit dc2b30b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/.gas-snapshot b/.gas-snapshot
@@ -97,28 +97,28 @@ ERC721Test:testFailDoubleBurn() (gas: 58965)
 ERC721Test:testFailDoubleMint() (gas: 53308)
 ERC721Test:testFailMintToZero() (gas: 5753)
 ERC721Test:testFailSafeMintToERC721RecipientWithWrongReturnData() (gas: 159032)
-ERC721Test:testFailSafeMintToERC721RecipientWithWrongReturnDataWithData() (gas: 159893)
+ERC721Test:testFailSafeMintToERC721RecipientWithWrongReturnDataWithData() (gas: 159853)
 ERC721Test:testFailSafeMintToNonERC721Recipient() (gas: 89187)
-ERC721Test:testFailSafeMintToNonERC721RecipientWithData() (gas: 90034)
+ERC721Test:testFailSafeMintToNonERC721RecipientWithData() (gas: 89994)
 ERC721Test:testFailSafeMintToRevertingERC721Recipient() (gas: 204765)
-ERC721Test:testFailSafeMintToRevertingERC721RecipientWithData() (gas: 205557)
+ERC721Test:testFailSafeMintToRevertingERC721RecipientWithData() (gas: 205517)
 ERC721Test:testFailSafeTransferFromToERC721RecipientWithWrongReturnData() (gas: 187276)
-ERC721Test:testFailSafeTransferFromToERC721RecipientWithWrongReturnDataWithData() (gas: 188028)
+ERC721Test:testFailSafeTransferFromToERC721RecipientWithWrongReturnDataWithData() (gas: 187685)
 ERC721Test:testFailSafeTransferFromToNonERC721Recipient() (gas: 117435)
-ERC721Test:testFailSafeTransferFromToNonERC721RecipientWithData() (gas: 118215)
+ERC721Test:testFailSafeTransferFromToNonERC721RecipientWithData() (gas: 117872)
 ERC721Test:testFailSafeTransferFromToRevertingERC721Recipient() (gas: 233009)
-ERC721Test:testFailSafeTransferFromToRevertingERC721RecipientWithData() (gas: 233738)
+ERC721Test:testFailSafeTransferFromToRevertingERC721RecipientWithData() (gas: 233395)
 ERC721Test:testFailTransferFromNotOwner() (gas: 57872)
 ERC721Test:testFailTransferFromToZero() (gas: 53403)
 ERC721Test:testFailTransferFromUnOwned() (gas: 8000)
 ERC721Test:testFailTransferFromWrongFrom() (gas: 53338)
 ERC721Test:testMint() (gas: 54278)
 ERC721Test:testSafeMintToEOA() (gas: 56913)
 ERC721Test:testSafeMintToERC721Recipient() (gas: 381679)
-ERC721Test:testSafeMintToERC721RecipientWithData() (gas: 402841)
+ERC721Test:testSafeMintToERC721RecipientWithData() (gas: 402801)
 ERC721Test:testSafeTransferFromToEOA() (gas: 509430)
 ERC721Test:testSafeTransferFromToERC721Recipient() (gas: 853875)
-ERC721Test:testSafeTransferFromToERC721RecipientWithData() (gas: 875037)
+ERC721Test:testSafeTransferFromToERC721RecipientWithData() (gas: 874696)
 ERC721Test:testTransferFrom() (gas: 487111)
 ERC721Test:testTransferFromApproveAll() (gas: 506662)
 ERC721Test:testTransferFromSelf() (gas: 64650)

diff --git a/src/tokens/ERC721.sol b/src/tokens/ERC721.sol
@@ -114,7 +114,7 @@ abstract contract ERC721 {
         address from,
         address to,
         uint256 id,
-        bytes memory data
+        bytes calldata data
     ) public virtual {
         transferFrom(from, to, id);