Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/aws-s3: console.error instead of throw for missing etag #5521

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

Murderlon
Copy link
Member

Closes #5516

@Murderlon Murderlon self-assigned this Nov 18, 2024
Copy link
Contributor

Diff output files
diff --git a/packages/@uppy/aws-s3/lib/index.js b/packages/@uppy/aws-s3/lib/index.js
index e312727..88fd867 100644
--- a/packages/@uppy/aws-s3/lib/index.js
+++ b/packages/@uppy/aws-s3/lib/index.js
@@ -501,15 +501,13 @@ export default class AwsS3Multipart extends BasePlugin {
           location,
         } = headersMap;
         if (method.toUpperCase() === "POST" && location == null) {
-          console.warn(
-            "AwsS3/Multipart: Could not read the Location header. This likely means CORS is not configured correctly on the S3 Bucket. See https://uppy.io/docs/aws-s3-multipart#S3-Bucket-Configuration for instructions.",
+          console.error(
+            "@uppy/aws-s3: Could not read the Location header. This likely means CORS is not configured correctly on the S3 Bucket. See https://uppy.io/docs/aws-s3/#setting-up-your-s3-bucket",
           );
         }
         if (etag == null) {
-          reject(
-            new Error(
-              "AwsS3/Multipart: Could not read the ETag header. This likely means CORS is not configured correctly on the S3 Bucket. See https://uppy.io/docs/aws-s3-multipart#S3-Bucket-Configuration for instructions.",
-            ),
+          console.error(
+            "@uppy/aws-s3: Could not read the ETag header. This likely means CORS is not configured correctly on the S3 Bucket. See https://uppy.io/docs/aws-s3/#setting-up-your-s3-bucket",
           );
           return;
         }

@Murderlon Murderlon merged commit 44a378a into main Nov 26, 2024
17 checks passed
@Murderlon Murderlon deleted the aws-etag-throw branch November 26, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants