Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/remote-sources: support companionKeysParams #5434

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

Murderlon
Copy link
Member

No description provided.

@Murderlon Murderlon requested review from mifi and aduh95 August 28, 2024 11:08
@Murderlon Murderlon self-assigned this Aug 28, 2024
Copy link
Contributor

Diff output files
diff --git a/packages/@uppy/remote-sources/lib/index.js b/packages/@uppy/remote-sources/lib/index.js
index d5dba0e..8ef79b4 100644
--- a/packages/@uppy/remote-sources/lib/index.js
+++ b/packages/@uppy/remote-sources/lib/index.js
@@ -62,9 +62,16 @@ export default class RemoteSources extends BasePlugin {
   }
   install() {
     this.opts.sources.forEach(pluginId => {
+      var _this$opts$companionK;
+      const {
+        sources,
+        ...rest
+      } = this.opts;
       const optsForRemoteSourcePlugin = {
-        ...this.opts,
-        sources: undefined,
+        ...rest,
+        companionKeysParams: (_this$opts$companionK = this.opts.companionKeysParams) == null
+          ? void 0
+          : _this$opts$companionK[pluginId],
       };
       const plugin = availablePlugins[pluginId];
       if (plugin == null) {

@Murderlon Murderlon merged commit 38bf2a7 into main Aug 28, 2024
17 checks passed
@Murderlon Murderlon deleted the remote-sources-companionKeysParams branch August 28, 2024 14:29
github-actions bot added a commit that referenced this pull request Aug 29, 2024
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/aws-s3           |   4.1.0 | @uppy/informer         |   4.1.0 |
| @uppy/box              |   3.1.0 | @uppy/instagram        |   4.1.0 |
| @uppy/companion        |   5.1.0 | @uppy/locales          |   4.1.0 |
| @uppy/companion-client |   4.1.0 | @uppy/onedrive         |   4.1.0 |
| @uppy/compressor       |   2.1.0 | @uppy/remote-sources   |   2.2.0 |
| @uppy/core             |   4.2.0 | @uppy/screen-capture   |   4.1.0 |
| @uppy/dashboard        |   4.1.0 | @uppy/tus              |   4.1.0 |
| @uppy/dropbox          |   4.1.0 | @uppy/unsplash         |   4.1.0 |
| @uppy/facebook         |   4.1.0 | @uppy/url              |   4.1.0 |
| @uppy/google-drive     |   4.1.0 | @uppy/xhr-upload       |   4.1.0 |
| @uppy/google-photos    |   0.3.0 | @uppy/zoom             |   3.1.0 |
| @uppy/image-editor     |   3.1.0 | uppy                   |   4.3.0 |

- @uppy/core,@uppy/dashboard: Pass container to `UIPlugin.render` for non-Preact integration (Merlijn Vos / #5437)
- @uppy/companion: do not use unsafe call to `JSON.stringify` (Antoine du Hamel / #5422)
- meta: Fix yarn.lock (Murderlon)
- @uppy/locales: Fix locale-pack for en_US (Merlijn Vos / #5431)
- meta: Add tsconfig to packages in private/ (Merlijn Vos / #5432)
- @uppy/remote-sources: support companionKeysParams (Merlijn Vos / #5434)
- @uppy/aws-s3,@uppy/box,@uppy/compressor,@uppy/dropbox,@uppy/facebook,@uppy/google-drive,@uppy/google-photos,@uppy/image-editor,@uppy/informer,@uppy/instagram,@uppy/onedrive,@uppy/screen-capture,@uppy/tus,@uppy/unsplash,@uppy/url,@uppy/xhr-upload,@uppy/zoom: export plugin options (Antoine du Hamel / #5433)
- docs: correctly list exported components (Merlijn Vos / #5417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants