Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/webcam: add missing types for recordedVideo #5208

Merged
merged 1 commit into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@uppy/webcam/src/CameraScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ interface CameraScreenProps extends VideoSourceSelectProps {

src: MediaStream | null
recording: boolean
recordedVideo: string | null
modes: string[]
supportsRecording: boolean
showVideoSourceDropdown: boolean
Expand Down Expand Up @@ -53,7 +54,6 @@ class CameraScreen extends Component<CameraScreenProps> {
render(): ComponentChild {
const {
src,
// @ts-expect-error TODO: remove unused
recordedVideo,
recording,
modes,
Expand Down
1 change: 1 addition & 0 deletions packages/@uppy/webcam/src/Webcam.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ interface WebcamState {
recordingLengthSeconds: number
videoSources: MediaDeviceInfo[]
currentDeviceId: null | string
recordedVideo: null | string
isRecording: boolean
[key: string]: unknown
}
Expand Down
Loading