Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant plugins prop from examples #5145

Merged
merged 4 commits into from
May 9, 2024
Merged

Remove redundant plugins prop from examples #5145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
768b22d
Remove redundant `plugins` prop from examples
Murderlon May 6, 2024
35b78d4
Fix format
Murderlon May 6, 2024
05c4bac
Maybe svelte code blocks make docusaurus crash
Murderlon May 6, 2024
096544c
Use svelte lang in codeblock
Murderlon May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/framework-integrations/react.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ function Component() {
// IMPORTANT: passing an initializer function to prevent Uppy from being reinstantiated on every render.
const [uppy] = useState(() => new Uppy().use(Webcam));

return <Dashboard uppy={uppy} plugins={['Webcam']} />;
return <Dashboard uppy={uppy} />;
}
```

Expand Down Expand Up @@ -180,7 +180,7 @@ function Component(props) {
uppy.getPlugin('Webcam').setOptions({ modes: props.webcamModes });
}, [props.webcamModes]);

return <Dashboard uppy={uppy} plugins={['Webcam']} />;
return <Dashboard uppy={uppy} />;
}
```

Expand Down
4 changes: 2 additions & 2 deletions docs/framework-integrations/svelte.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ instance can be passed into components as an `uppy` prop. Due to the way Svelte
handles reactivity, you can initialize Uppy the same way you would with vanilla
JavaScript.

```html
```svelte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you validate if Docosorus is still doing syntax highlighting with this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite confident it should

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried, the syntax highlighting is gone

<script>
import { Dashboard } from '@uppy/svelte';
import Uppy from '@uppy/core';
Expand All @@ -64,7 +64,7 @@ JavaScript.
const uppy = new Uppy().use(Webcam);
</script>

<main><Dashboard uppy={uppy} plugins={["Webcam"]} /></main>
<main><Dashboard uppy={uppy} /></main>
```

[svelte]: https://svelte.dev
2 changes: 1 addition & 1 deletion docs/framework-integrations/vue.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ JavaScript.
</script>

<template>
<Dashboard :uppy="uppy" :plugins="['Webcam']" />
<Dashboard :uppy="uppy" />
</template>
```

Expand Down
Loading