@uppy/aws-s3-multipart: pass signal as separate arg for backward compat
#4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murderlon
approved these changes
Oct 19, 2023
github-actions bot
added a commit
that referenced
this pull request
Oct 20, 2023
| Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/angular | 0.6.1 | @uppy/progress-bar | 3.0.4 | | @uppy/audio | 1.1.4 | @uppy/provider-views | 3.6.0 | | @uppy/aws-s3 | 3.4.0 | @uppy/react | 3.1.4 | | @uppy/aws-s3-multipart | 3.8.0 | @uppy/remote-sources | 1.1.0 | | @uppy/box | 2.1.4 | @uppy/screen-capture | 3.1.3 | | @uppy/companion | 4.10.0 | @uppy/status-bar | 3.2.5 | | @uppy/companion-client | 3.5.0 | @uppy/store-default | 3.0.5 | | @uppy/compressor | 1.0.5 | @uppy/store-redux | 3.0.5 | | @uppy/core | 3.6.0 | @uppy/svelte | 3.1.1 | | @uppy/dashboard | 3.6.0 | @uppy/thumbnail-generator | 3.0.6 | | @uppy/drop-target | 2.0.2 | @uppy/transloadit | 3.3.2 | | @uppy/dropbox | 3.1.4 | @uppy/tus | 3.3.2 | | @uppy/facebook | 3.1.3 | @uppy/unsplash | 3.2.3 | | @uppy/file-input | 3.0.4 | @uppy/url | 3.3.4 | | @uppy/form | 3.0.3 | @uppy/utils | 5.5.2 | | @uppy/golden-retriever | 3.1.1 | @uppy/vue | 1.1.0 | | @uppy/google-drive | 3.3.0 | @uppy/webcam | 3.3.4 | | @uppy/image-editor | 2.2.2 | @uppy/xhr-upload | 3.4.2 | | @uppy/informer | 3.0.4 | @uppy/zoom | 2.1.3 | | @uppy/instagram | 3.1.3 | uppy | 3.18.0 | | @uppy/onedrive | 3.1.4 | | | - @uppy/aws-s3-multipart: fix `TypeError` (Antoine du Hamel / #4748) - meta: Bump tough-cookie from 4.1.2 to 4.1.3 (dependabot[bot] / #4750) - meta: example: simplify code by using built-in `throwIfAborted` (Antoine du Hamel / #4749) - @uppy/aws-s3-multipart: pass `signal` as separate arg for backward compat (Antoine du Hamel / #4746) - meta: fix TS integration (Antoine du Hamel / #4741) - meta: fix js2ts check (Antoine du Hamel) - meta: add support for TypeScript plugins (Antoine du Hamel / #4640) - @uppy/vue: export FileInput (mdxiaohu / #4736) - meta: examples: update `server.py` (codehero7386 / #4732) - @uppy/aws-s3-multipart: fix `uploadURL` when using `PUT` (Antoine du Hamel / #4701) - @uppy/dashboard: auto discover and install plugins without target (Artur Paikin / #4343) - meta: e2e: upgrade Cypress (Antoine du Hamel / #4731) - @uppy/core: mark the package as side-effect free (Antoine du Hamel / #4730) - meta: Bump postcss from 8.4.16 to 8.4.31 (dependabot[bot] / #4723) - meta: test with the latest versions of Node.js (Antoine du Hamel / #4729) - meta: e2e: update Parcel (Antoine du Hamel / #4726) - meta: uppy: fix types (Antoine du Hamel / #4721) - @uppy/core: type more events (Antoine du Hamel / #4719) - @uppy/svelte: fix TS build command (Antoine du Hamel / #4720) - @uppy/companion: Bucket fn also remote files (Mikael Finstad / #4693) - @uppy/companion-client: fixup! Added Companion OAuth Key type (Murderlon / #4668) - @uppy/companion-client: Added Companion OAuth Key type (Chris Pratt / #4668) - meta: check for formatting in CI (Antoine du Hamel / #4714) - meta: bump get-func-name from 2.0.0 to 2.0.2 (dependabot[bot] / #4709) - meta: run Prettier on existing files (Antoine du Hamel / #4713)
Murderlon
added a commit
that referenced
this pull request
Nov 1, 2023
* main: More image editor improvements (#4676) @uppy/react: add useUppyState (#4711) Release: [email protected] (#4760) Bump jsonwebtoken from 8.5.1 to 9.0.0 in /packages/@uppy/companion (#4751) Bump react-devtools-core from 4.25.0 to 4.28.4 (#4756) Bump webpack from 5.74.0 to 5.88.2 (#4740) Bump @babel/traverse from 7.22.5 to 7.23.2 (#4739) @uppy/core: fix `sideEffects` declaration (#4759) Release: [email protected] (#4754) @uppy/aws-s3-multipart: fix `TypeError` (#4748) Bump tough-cookie from 4.1.2 to 4.1.3 (#4750) example: simplify code by using built-in `throwIfAborted` (#4749) @uppy/aws-s3-multipart: pass `signal` as separate arg for backward compat (#4746) meta: fix TS integration (#4741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ideal design, but better than making a breaking change. Some of our methods are expecting the
signalto be a separate argument instead of being in the options bag. It shouldn't be a problem to pass the sameAbortSignaltwice, hopefully that's something we can fix in a future major.