-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example: update CDN example #3803
Conversation
947d2e7
to
22016a9
Compare
examples/cdn-example/package.json
Outdated
"private": true | ||
"private": true, | ||
"scripts": { | ||
"dev": "deno run --allow-net --allow-read https://deno.land/std/http/file_server.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deno, was this for testing? As I don’t think we require the deno binary to run the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes for testing. Technically we don’t need a web server at all, we could open the html file directly.
| Package | Version | Package | Version | | -------------------- | ------------ | -------------------- | ------------ | | @uppy/companion | 4.0.0-beta.1 | @uppy/transloadit | 3.0.0-beta.2 | | @uppy/locales | 3.0.0-beta.2 | @uppy/robodog | 3.0.0-beta.2 | | @uppy/provider-views | 3.0.0-beta.2 | uppy | 3.0.0-beta.2 | - example: fix `custom-provider` example (Antoine du Hamel / #3854) - example: fix Vue3 example (Antoine du Hamel / #3774) - @uppy/companion: remove deprecated duplicated metrics (Mikael Finstad / #3833) - example: update CDN example (Antoine du Hamel / #3803) - @uppy/companion: Companion 3 default to no s3 acl (Mikael Finstad / #3826) - @uppy/companion: rewrite companion.app() to return an object (Mikael Finstad / #3827) - @uppy/companion: remove companion provider compat api (Mikael Finstad / #3828) - @uppy/companion: rewrite code for node >=14 (Mikael Finstad / #3829) - @uppy/companion: remove chunkSize backwards compatibility (Mikael Finstad / #3830) - @uppy/companion: Companion: make `emitSuccess` and `emitError` private (Mikael Finstad / #3832) - @uppy/companion: do not use a default upload protocol (Mikael Finstad / #3834)
| Package | Version | Package | Version | | -------------------- | ------------ | -------------------- | ------------ | | @uppy/companion | 4.0.0-beta.1 | @uppy/transloadit | 3.0.0-beta.2 | | @uppy/locales | 3.0.0-beta.2 | @uppy/robodog | 3.0.0-beta.2 | | @uppy/provider-views | 3.0.0-beta.2 | uppy | 3.0.0-beta.2 | - example: fix `custom-provider` example (Antoine du Hamel / transloadit#3854) - example: fix Vue3 example (Antoine du Hamel / transloadit#3774) - @uppy/companion: remove deprecated duplicated metrics (Mikael Finstad / transloadit#3833) - example: update CDN example (Antoine du Hamel / transloadit#3803) - @uppy/companion: Companion 3 default to no s3 acl (Mikael Finstad / transloadit#3826) - @uppy/companion: rewrite companion.app() to return an object (Mikael Finstad / transloadit#3827) - @uppy/companion: remove companion provider compat api (Mikael Finstad / transloadit#3828) - @uppy/companion: rewrite code for node >=14 (Mikael Finstad / transloadit#3829) - @uppy/companion: remove chunkSize backwards compatibility (Mikael Finstad / transloadit#3830) - @uppy/companion: Companion: make `emitSuccess` and `emitError` private (Mikael Finstad / transloadit#3832) - @uppy/companion: do not use a default upload protocol (Mikael Finstad / transloadit#3834)
Having ESM in the CDN bundle is nice, actually.