Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: fix CDN bundle #3494

Merged
merged 2 commits into from
Feb 17, 2022
Merged

meta: fix CDN bundle #3494

merged 2 commits into from
Feb 17, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 16, 2022

Make Uppy available on the global scope when loaded from the CDN bundle.

@aduh95 aduh95 requested a review from arturi February 16, 2022 15:00
@arturi
Copy link
Contributor

arturi commented Feb 16, 2022

Thanks, could you clarify, what changed? On the surface it looks like shuffling things around and removing polyfills from the regular bundle, leaving them in legacy, but no mention of window.

@aduh95
Copy link
Contributor Author

aduh95 commented Feb 16, 2022

globalThis === window in browser context. As it the build-bundle.js was set up, it was adding Uppy to the global object only on the legacy bundle. To fix that, I've created a separate file for the bundle legacy and the non-legacy one so both will add Uppy to the global object, and only the legacy one contains polyfills.

@aduh95 aduh95 merged commit 3817497 into transloadit:main Feb 17, 2022
github-actions bot added a commit that referenced this pull request Feb 17, 2022
| Package         | Version | Package         | Version |
| --------------- | ------- | --------------- | ------- |
| @uppy/companion |   3.3.0 | uppy            |   2.6.0 |
| @uppy/robodog   |   2.3.2 |                 |         |

- meta: warn about not merging PR manually (Artur Paikin / #3492)
- @uppy/companion: fix unpslash author meta, sanitize metadata to strings and improve companion tests (Mikael Finstad / #3478)
- meta: ensure README is correctly formatted when doing releases (Antoine du Hamel / #3499)
- meta: fix CDN bundle (Antoine du Hamel / #3494)
- meta: fix missing EOL and end of e2e test templates (Antoine du Hamel / #3484)
- meta: use a single `.env` file for config (Antoine du Hamel / #3498)
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package         | Version | Package         | Version |
| --------------- | ------- | --------------- | ------- |
| @uppy/companion |   3.3.0 | uppy            |   2.6.0 |
| @uppy/robodog   |   2.3.2 |                 |         |

- meta: warn about not merging PR manually (Artur Paikin / transloadit#3492)
- @uppy/companion: fix unpslash author meta, sanitize metadata to strings and improve companion tests (Mikael Finstad / transloadit#3478)
- meta: ensure README is correctly formatted when doing releases (Antoine du Hamel / transloadit#3499)
- meta: fix CDN bundle (Antoine du Hamel / transloadit#3494)
- meta: fix missing EOL and end of e2e test templates (Antoine du Hamel / transloadit#3484)
- meta: use a single `.env` file for config (Antoine du Hamel / transloadit#3498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants