meta: add support for ESM sources in build script #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
force-pushed
the
add-esm-support
branch
from
3d0ae3d to
a73869a
Compare
aduh95
force-pushed
the
add-esm-support
branch
from
0fcb722 to
3b40c3b
Compare
arturi
approved these changes
Feb 15, 2022
arturi
reviewed
Feb 15, 2022
| } | ||
| }, | ||
| }, | ||
| }] : undefined |
There was a problem hiding this comment.
Ideally maybe refactor in the future — hard to follow
github-actions bot
added a commit
that referenced
this pull request
Feb 16, 2022
| Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/companion | 3.2.1 | @uppy/thumbnail-generator | 2.1.1 | | @uppy/compressor | 0.2.2 | @uppy/robodog | 2.3.1 | | @uppy/onedrive | 2.0.6 | uppy | 2.5.1 | - meta: Missing comma and wrong attribute name on cors example config (Edgar Santiago / #3465) - @uppy/onedrive: Update README.md (Márton László Attila / #3489) - @uppy/compressor: Add image compressor plugin (Artur Paikin / #3471) - @uppy/companion: fix periodicPingUrls oops (Mikael Finstad / #3490) - meta: add support for ESM sources in build script (Antoine du Hamel / #3468)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/companion | 3.2.1 | @uppy/thumbnail-generator | 2.1.1 | | @uppy/compressor | 0.2.2 | @uppy/robodog | 2.3.1 | | @uppy/onedrive | 2.0.6 | uppy | 2.5.1 | - meta: Missing comma and wrong attribute name on cors example config (Edgar Santiago / transloadit#3465) - @uppy/onedrive: Update README.md (Márton László Attila / transloadit#3489) - @uppy/compressor: Add image compressor plugin (Artur Paikin / transloadit#3471) - @uppy/companion: fix periodicPingUrls oops (Mikael Finstad / transloadit#3490) - meta: add support for ESM sources in build script (Antoine du Hamel / transloadit#3468)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ESM in
.jsand.jsxfiles.And don't try to
mkdirthe lib folder if we already know it exists.