-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: move configuration to a .env
file
#3430
Conversation
Putting the dev config in a git-ignored files improves DX and lower the risk of a private dev key being commited by mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! As it's only used in private/dev/
I think it's better to put the .env
file in there.
.env.development
Outdated
@@ -0,0 +1,24 @@ | |||
VITE_UPLOADER=tus | |||
|
|||
#### To customize this, create a .env.dev.local file that overrides those values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it's .env.development
but .env.dev.local
(instead of both dev
or both development
)
* main: dev: move configuration to a `.env` file (#3430) Update ci.yml (#3428) @uppy/transloadit: simplify `#onTusError` (#3419) Force include babel numeric separator (#3422) Release: [email protected] (#3420) @uppy/transloadit: ignore rate limiting errors when polling (#3418) @uppy/tus: pause all requests in response to server rate limiting (#3394) @uppy/transloadit: better defaults for rate limiting (#3414) Update BACKLOG.md Fix Companion deploys (#3388) update aws-presigned-url example to use esm (#3413) @uppy/image-editor: namespace input range css (#3406) Release: [email protected] (#3410) improve private ip check (#3403) Add missing option to the screen capture types (#3400) @uppy/drag-drop: fix `undefined is not a function` TypeError (#3397) website: update december 2021 blog post (#3396)
| Package | Version | Package | Version | | ----------------- | ------- | ----------------- | ------- | | @uppy/transloadit | 2.1.1 | uppy | 2.4.1 | | @uppy/robodog | 2.2.1 | | | - @uppy/transloadit: fix handling of Tus errors and rate limiting (Antoine du Hamel / #3429) - meta: Add Unsplash to website dashboard example (Merlijn Vos / #3431) - meta: dev: move configuration to a `.env` file (Antoine du Hamel / #3430) - meta: Update ci.yml (Kevin van Zonneveld / #3428) - @uppy/transloadit: simplify `#onTusError` (Antoine du Hamel / #3419) - meta: Force include babel numeric separator (Merlijn Vos / #3422)
* main: dev: move configuration to a `.env` file (transloadit#3430) Update ci.yml (transloadit#3428) @uppy/transloadit: simplify `#onTusError` (transloadit#3419) Force include babel numeric separator (transloadit#3422) Release: [email protected] (transloadit#3420) @uppy/transloadit: ignore rate limiting errors when polling (transloadit#3418) @uppy/tus: pause all requests in response to server rate limiting (transloadit#3394) @uppy/transloadit: better defaults for rate limiting (transloadit#3414) Update BACKLOG.md Fix Companion deploys (transloadit#3388) update aws-presigned-url example to use esm (transloadit#3413) @uppy/image-editor: namespace input range css (transloadit#3406) Release: [email protected] (transloadit#3410) improve private ip check (transloadit#3403) Add missing option to the screen capture types (transloadit#3400) @uppy/drag-drop: fix `undefined is not a function` TypeError (transloadit#3397) website: update december 2021 blog post (transloadit#3396)
Putting the dev config in a git-ignored files improves DX and lower the
risk of a private dev key being commited by mistake.