Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: replace browserify with esbuild #3363

Merged
merged 8 commits into from
Jan 13, 2022
Merged

meta: replace browserify with esbuild #3363

merged 8 commits into from
Jan 13, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 13, 2021

Switch to ESBuild for building the bundle and the website examples.
This change is necessary to prepare for the transition to ESM (browserify doesn't support ESM), and also has the nice side effect to speed up the build process, and reduce the bundle size (from 557K to 517K). On the other hand, we also have to give up disc which is browserify centered, and it doesn't look like there's an obvious replacement for it. Also, ESBuild is much more efficient when producing directly the minified bundle, so only the *.min.js bundle are generated by default (it's stll possible to generate them without the minification if we need to debug it).

I had to change one example that was using crypto (which is not available in the browser, I suppose browserify was bundling a polyfill).

@aduh95 aduh95 mentioned this pull request Dec 13, 2021
Merged
Murderlon
Murderlon reviewed Dec 13, 2021
View reviewed changes
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall. Some tests are still failing though

@aduh95
Copy link
Contributor Author

aduh95 commented Dec 13, 2021 •
edited
Loading

Some tests are still failing though

Blocked on #3367.

EDIT: there are still broken tests in the E2E suite that expects to find Browserify. I'll have to update those.
EDIT2: Done! CI is green 🎉

This was referenced Dec 15, 2021
Closed
Merged
@Murderlon Murderlon mentioned this pull request Jan 5, 2022
Merged
@aduh95 aduh95 mentioned this pull request Jan 5, 2022
Merged
@kvz
Copy link
Member

kvz commented Jan 6, 2022

EDIT2: Done! CI is green 🎉

What is this waiting on?

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 6, 2022

EDIT2: Done! CI is green 🎉

What is this waiting on?

Reviews mostly. We should also probably what effect this change has on uppy.io on different browsers, which I haven't done yet.

@aduh95 aduh95 merged commit 848aa85 into main Jan 13, 2022
@aduh95 aduh95 deleted the no-more-browserify branch January 13, 2022 14:22
@aduh95 aduh95 mentioned this pull request Jan 13, 2022
Merged
Murderlon added a commit that referenced this pull request Jan 21, 2022
@Murderlon
Merge branch 'main' into cypress
eb92b39 
* main:
  dev: fix Vite custom plugin (#3437)
  website: add legacy bundle to CDN example (#3433)
  meta: remove unused lerna and npm files (#3436)
  meta: replace browserify with esbuild (#3363)
  Release: [email protected] (#3432)
Murderlon added a commit that referenced this pull request Feb 1, 2022
@Murderlon
Merge branch 'main' into missing-types
a6eb595 
* main:
  Upgrade size-limit to 7.0.5 (#3445)
  Unsplash: UI improvements (#3438)
  @uppy/thumbnail-generator: exifr: remove legacy IE support (#3382)
  Default to HEAD requests when the Companion looks to get meta information about a URL (#3417)
  check if info array is empty (#3442)
  dev: fix Vite custom plugin (#3437)
  website: add legacy bundle to CDN example (#3433)
  meta: remove unused lerna and npm files (#3436)
  meta: replace browserify with esbuild (#3363)
  Release: [email protected] (#3432)
  @uppy/transloadit: fix handling of Tus errors and rate limiting (#3429)
  Add Unsplash to website dashboard example (#3431)
@github-actions github-actions bot mentioned this pull request Feb 14, 2022
Merged
@aduh95 aduh95 mentioned this pull request Feb 14, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Feb 14, 2022
@aduh95
Release: [email protected] (#3487)
c3340a6 
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/companion           |   3.2.0 | @uppy/provider-views      |   2.0.7 |
| @uppy/companion-client    |   2.0.5 | @uppy/thumbnail-generator |   2.1.0 |
| @uppy/core                |   2.1.5 | @uppy/robodog             |   2.3.0 |
| @uppy/dashboard           |   2.1.4 | uppy                      |   2.5.0 |
| @uppy/locales             |   2.0.6 |                           |         |

- @uppy/companion: add support for COMPANION_UNSPLASH_SECRET (Mikael Finstad / #3463)
- @uppy/unsplash: fix nested meta (Artur Paikin / #3485)
- meta: fix(docs): typo in property `thumbnailType` (Dan Schalow / #3472)
- @uppy/robodog: add audio, box, unsplash, screen-capture to Robodog (Artur Paikin / #3483)
- meta: consolidate ENV files and fix contributing guidelines (Antoine du Hamel / #3475)
- @uppy/companion-client,@uppy/companion,@uppy/provider-views,@uppy/robodog: Finishing touches on Companion dynamic Oauth (Renée Kooi / #2802)
- meta: Improve companion docs (Mikael Finstad / #3479)
- meta: Make E2E Great Again (Merlijn Vos / #3444)
- meta: Add PostCSS handling to Vite (Artur Paikin / #3467)
- meta: Update CONTRIBUTING.md (Mikael Finstad / #3411)
- @uppy/companion: fix broken thumbnails for box and dropbox (Mikael Finstad / #3460)
- website: fix `Uppy is not defined` error (Antoine du Hamel / #3461)
- @uppy/companion: Implement periodic ping functionality (Mikael Finstad / #3246)
- @uppy/companion: fix callback urls (Mikael Finstad / #3458)
- @uppy/core,@uppy/dashboard,@uppy/thumbnail-generator: Add dashboard and UIPlugin types (Merlijn Vos / #3426)
- @uppy/locales: Add "save" to fr_FR.js (Charly Billaud / #3395)
- @uppy/companion: Fix TypeError when invalid initialization vector (Julian Gruber / #3416)
- meta: Upgrade size-limit to 7.0.5 (Artur Paikin / #3445)
- @uppy/provider-views: Unsplash: UI improvements (Artur Paikin / #3438)
- @uppy/thumbnail-generator: exifr: remove legacy IE support (Artur Paikin / #3382)
- @uppy/companion: Default to HEAD requests when the Companion looks to get meta information about a URL (Zack Bloom / #3417)
- @uppy/dashboard: check if info array is empty (Artur Paikin / #3442)
- meta: dev: fix Vite custom plugin (Antoine du Hamel / #3437)
- website: add legacy bundle to CDN example (Antoine du Hamel / #3433)
- meta: remove unused lerna and npm files (Antoine du Hamel / #3436)
- meta: replace browserify with esbuild (Antoine du Hamel / #3363)
vymao pushed a commit to vymao/uppy that referenced this pull request Mar 29, 2022
@Murderlon
Merge branch 'main' into cypress
213a8ce 
* main:
  dev: fix Vite custom plugin (transloadit#3437)
  website: add legacy bundle to CDN example (transloadit#3433)
  meta: remove unused lerna and npm files (transloadit#3436)
  meta: replace browserify with esbuild (transloadit#3363)
  Release: [email protected] (transloadit#3432)
aduh95 added a commit to aduh95/uppy that referenced this pull request Sep 21, 2022
@aduh95
website: remove references to the deleted disc.html page
14fcfeb 
Refs: transloadit#3363
@aduh95 aduh95 mentioned this pull request Sep 21, 2022
Merged
aduh95 added a commit that referenced this pull request Sep 21, 2022
@aduh95
website: remove references to the deleted disc.html page (#4119)
c2b31d0 
Refs: #3363
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
@aduh95
Release: [email protected] (transloadit#3487)
83148b2 
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/companion           |   3.2.0 | @uppy/provider-views      |   2.0.7 |
| @uppy/companion-client    |   2.0.5 | @uppy/thumbnail-generator |   2.1.0 |
| @uppy/core                |   2.1.5 | @uppy/robodog             |   2.3.0 |
| @uppy/dashboard           |   2.1.4 | uppy                      |   2.5.0 |
| @uppy/locales             |   2.0.6 |                           |         |

- @uppy/companion: add support for COMPANION_UNSPLASH_SECRET (Mikael Finstad / transloadit#3463)
- @uppy/unsplash: fix nested meta (Artur Paikin / transloadit#3485)
- meta: fix(docs): typo in property `thumbnailType` (Dan Schalow / transloadit#3472)
- @uppy/robodog: add audio, box, unsplash, screen-capture to Robodog (Artur Paikin / transloadit#3483)
- meta: consolidate ENV files and fix contributing guidelines (Antoine du Hamel / transloadit#3475)
- @uppy/companion-client,@uppy/companion,@uppy/provider-views,@uppy/robodog: Finishing touches on Companion dynamic Oauth (Renée Kooi / transloadit#2802)
- meta: Improve companion docs (Mikael Finstad / transloadit#3479)
- meta: Make E2E Great Again (Merlijn Vos / transloadit#3444)
- meta: Add PostCSS handling to Vite (Artur Paikin / transloadit#3467)
- meta: Update CONTRIBUTING.md (Mikael Finstad / transloadit#3411)
- @uppy/companion: fix broken thumbnails for box and dropbox (Mikael Finstad / transloadit#3460)
- website: fix `Uppy is not defined` error (Antoine du Hamel / transloadit#3461)
- @uppy/companion: Implement periodic ping functionality (Mikael Finstad / transloadit#3246)
- @uppy/companion: fix callback urls (Mikael Finstad / transloadit#3458)
- @uppy/core,@uppy/dashboard,@uppy/thumbnail-generator: Add dashboard and UIPlugin types (Merlijn Vos / transloadit#3426)
- @uppy/locales: Add "save" to fr_FR.js (Charly Billaud / transloadit#3395)
- @uppy/companion: Fix TypeError when invalid initialization vector (Julian Gruber / transloadit#3416)
- meta: Upgrade size-limit to 7.0.5 (Artur Paikin / transloadit#3445)
- @uppy/provider-views: Unsplash: UI improvements (Artur Paikin / transloadit#3438)
- @uppy/thumbnail-generator: exifr: remove legacy IE support (Artur Paikin / transloadit#3382)
- @uppy/companion: Default to HEAD requests when the Companion looks to get meta information about a URL (Zack Bloom / transloadit#3417)
- @uppy/dashboard: check if info array is empty (Artur Paikin / transloadit#3442)
- meta: dev: fix Vite custom plugin (Antoine du Hamel / transloadit#3437)
- website: add legacy bundle to CDN example (Antoine du Hamel / transloadit#3433)
- meta: remove unused lerna and npm files (Antoine du Hamel / transloadit#3436)
- meta: replace browserify with esbuild (Antoine du Hamel / transloadit#3363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturi arturi arturi approved these changes

@Murderlon Murderlon Murderlon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @kvz @arturi @Murderlon