meta: use Vite for examples/dev #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bit hacky, but it works :) We should be getting even more performance when we switch to ESM and stop using JSX in `.js` files.
Murderlon
reviewed
Dec 13, 2021
There was a problem hiding this comment.
I was also thinking of doing this. Though I was thinking of creating a scratch or dev folder in root and keep examples simple and, well, for actual examples (like Nextjs).
Opinions on that?
|
Not sure, but I think it can be done in a separate PR. This one focuses on updating the existing example to make it use Vite instead of Browserify. |
|
Can be done in a separate PR, but I’m leaning towards an agreement on that |
Murderlon
approved these changes
Dec 13, 2021
github-actions bot
added a commit
that referenced
this pull request
Dec 21, 2021
| Package | Version | Package | Version | | --------------- | ------- | --------------- | ------- | | @uppy/angular | 0.2.8 | @uppy/vue | 0.4.5 | | @uppy/companion | 3.1.4 | uppy | 2.3.2 | | @uppy/svelte | 1.0.7 | | | - meta: fix release script (Antoine du Hamel) - @uppy/core: document file.name (Merlijn Vos / #3381) - @uppy/angular,@uppy/companion,@uppy/svelte,@uppy/vue: add `.npmignore` files to ignore `.gitignore` when packing (Antoine du Hamel / #3380) - meta: add VSCode workspace settings to `.gitignore` (Antoine du Hamel) - @uppy/companion: Upgrade ws in companion (Merlijn Vos / #3377) - meta: use ESBuild to bundle in E2E test suite (Antoine du Hamel / #3375) - meta: update linter config to parse ESM files (Antoine du Hamel / #3371) - meta: move dev workspace to `private/` (Antoine du Hamel / #3368) - meta: use Vite for examples/dev (Antoine du Hamel / #3361) - website: remove dependency on `crypto` in @uppy/transloadit example (Antoine du Hamel / #3367) - meta: enable linter on website examples (Antoine du Hamel / #3366) - meta: enable linter on mjs scripts (Antoine du Hamel / #3364) - @uppy/angular: Fix module field in `package.json` (Merlijn Vos / #3365) - meta: improve release script wording and formatting (Artur Paikin)
Murderlon
added a commit
that referenced
this pull request
Jan 12, 2022
* main: (45 commits) Polished the latest update blog (#3390) docs: fix typo in audio.md (#3389) website: 2.0-2.3 post draft (#3370) Release: [email protected] (#3383) meta: fix release script @uppy/core: document file.name (#3381) add `.npmignore` files to ignore .gitignore when packing (#3380) meta: add VSCode workspace settings to `.gitignore` Upgrade ws in companion (#3377) meta: use ESBuild to bundle in E2E test suite (#3375) meta: update linter config to parse ESM files (#3371) meta: move dev workspace to `private/` (#3368) meta: use Vite for examples/dev (#3361) website: remove dependency on `crypto` in @uppy/transloadit example (#3367) tools: enable linter on website examples (#3366) meta: enable linter on mjs scripts (#3364) Fix module field in @uppy/angular package.json (#3365) Release: [email protected] (#3357) meta: improve release script wording and formatting meta: update npm deps (#3352) ...
vymao
pushed a commit
to vymao/uppy
that referenced
this pull request
Mar 29, 2022
* main: (45 commits) Polished the latest update blog (transloadit#3390) docs: fix typo in audio.md (transloadit#3389) website: 2.0-2.3 post draft (transloadit#3370) Release: [email protected] (transloadit#3383) meta: fix release script @uppy/core: document file.name (transloadit#3381) add `.npmignore` files to ignore .gitignore when packing (transloadit#3380) meta: add VSCode workspace settings to `.gitignore` Upgrade ws in companion (transloadit#3377) meta: use ESBuild to bundle in E2E test suite (transloadit#3375) meta: update linter config to parse ESM files (transloadit#3371) meta: move dev workspace to `private/` (transloadit#3368) meta: use Vite for examples/dev (transloadit#3361) website: remove dependency on `crypto` in @uppy/transloadit example (transloadit#3367) tools: enable linter on website examples (transloadit#3366) meta: enable linter on mjs scripts (transloadit#3364) Fix module field in @uppy/angular package.json (transloadit#3365) Release: [email protected] (transloadit#3357) meta: improve release script wording and formatting meta: update npm deps (transloadit#3352) ...
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | --------------- | ------- | --------------- | ------- | | @uppy/angular | 0.2.8 | @uppy/vue | 0.4.5 | | @uppy/companion | 3.1.4 | uppy | 2.3.2 | | @uppy/svelte | 1.0.7 | | | - meta: fix release script (Antoine du Hamel) - @uppy/core: document file.name (Merlijn Vos / transloadit#3381) - @uppy/angular,@uppy/companion,@uppy/svelte,@uppy/vue: add `.npmignore` files to ignore `.gitignore` when packing (Antoine du Hamel / transloadit#3380) - meta: add VSCode workspace settings to `.gitignore` (Antoine du Hamel) - @uppy/companion: Upgrade ws in companion (Merlijn Vos / transloadit#3377) - meta: use ESBuild to bundle in E2E test suite (Antoine du Hamel / transloadit#3375) - meta: update linter config to parse ESM files (Antoine du Hamel / transloadit#3371) - meta: move dev workspace to `private/` (Antoine du Hamel / transloadit#3368) - meta: use Vite for examples/dev (Antoine du Hamel / transloadit#3361) - website: remove dependency on `crypto` in @uppy/transloadit example (Antoine du Hamel / transloadit#3367) - meta: enable linter on website examples (Antoine du Hamel / transloadit#3366) - meta: enable linter on mjs scripts (Antoine du Hamel / transloadit#3364) - @uppy/angular: Fix module field in `package.json` (Merlijn Vos / transloadit#3365) - meta: improve release script wording and formatting (Artur Paikin)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit hacky, but it works :)
We should be getting even more performance when we switch to ESM and
stop using JSX in
.jsfiles.Next step would be to migrate the website to Vite (EDIT: probably not, the website is using Hexo there's no reason to move away from it), and the bundle to ESBuild.