-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: use Yarn v3 instead of npm #3237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we can rid of lerna
? We also depended on lerna for determining which packages were touched since the last release and what versions they will become. I'm not sure if that's in yarn workspaces as well?
@goto-bus-stop Renée, we could definitely use your expertise in reviewing this, please. |
Is there something specific you'd like me to look at? it high-level looks good to me, i'm not familiar with corepack or yarn 3. |
A note in |
8105e61
to
2e94741
Compare
Added, PTAL.
I reverted this, we will explore replacing |
8486423
to
ffcd577
Compare
* main: Disable drop state for non-files (#2449) meta: use Yarn v3 instead of npm (#3237) examples: Update to Parcel 2 (#3275) ci: test Companion with Node.js 16.x (#3273) e2e tests: Move transloadit2 test into transloadit, remove the former (#3271) Release ci: fix tranloadit2 e2e tests (#3270) Add unique class to discard button (#3269)
Left overs from 01d7ea1 (transloadit#3237).
* meta: use Yarn v3 instead of npm * Update CONTRIBUTING.md to fix linter errors * remove remaining npm commands * Update deps
Introduce use of Yarn (Berry) instead of npm+lerna. It's recommended to use Corepack rather than downloading
yarn
directly. It's included with Node.js v16.x, or can be installed withnpm install -g corepack
on Node.js v14.x.CI is passing, but there might be stuff to test before merging to ensure every thing keeps working. Main changes are:
removewe are keepinglerna
as it looks like yarn workspaces cover all the use we had for it.lerna
for the releases for the time being.create-react-app
is still tested withnpm
as I believe it's the most common scenario.file:
protocol inpackage.json
s with Yarn'sworkspace:
protocol.Checkout https://yarnpkg.com/getting-started/migration for documentation regarding yarn's commands.
Notice: if running
yarn --version
in the root of this repo returns you something like1.xx.xx
, it means you have ayarn
binary in your path that is not provided by Corepack. You should be able to runcorepack yarn
instead ofyarn
:corepack yarn --version
always return3.0.2
.Get started with the following commands: