core: add postprocess progress when upload success #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaej
force-pushed
the
master
branch
2 times, most recently
from
3e8212f to
a072d19
Compare
I don't believe they are, but I may be wrong about that. You could try using something like |
|
Hi @goto-bus-stop, do you guys think this change will be implemented in an upcoming version? |
|
Sorry for the delay! Yes, will be out in the next release. We just did one recently, so likely by the end of the month, unless some change will require a quicker turnaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for this issue. I don't know if this is the best way to solve the bug but It works in my case. The
postprocessproperty should be set up if there is any postprocessor, that way the success icon is not going to appear at the end ofupload-success. That is possible because there is an existing validation in a dashboard component that checks for that property.Question: Are the packages of this PR deployed somewhere? I need to use my forked version but it is becoming complicated since uppy uses mono repo and can't just simple do
yarn add https://github.com/myaccount/forked-reposince I only need @uppy/core from my forked version.