-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lerna link convert #1730
lerna link convert #1730
Conversation
Since typescript doesn't actually transform anything, we can just use this. In a next major version we could set `noEmit: true` in the tsconfig and stop publishing `lib`.
We should update docs probably, everywhere we say to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Looking forward to not running bootstrap
:) Checked dev example, website and some examples locally — all worked.
Ahh, think I figured out the CI failure finally. |
* lerna link convert * ci: use npm ci * update lockfile * companion: set `bin` to source file Since typescript doesn't actually transform anything, we can just use this. In a next major version we could set `noEmit: true` in the tsconfig and stop publishing `lib`. * companion: do chmod +x on start-server.js * build: remove obsolete lerna config * build: explicitly install latest versions when building e2e tests for ci * Remove versions from private packages * fix regex * try fix * ci: force npm to install to endtoend folder * ci: fold up e2e build output * Update netlify deploy preview command * Remove mentions of npm run bootstrap * Edit .github/CONTRIBUTING.md instead * companion: add proxy executable * companion: fix publish * Downgrade jest to appease create-react-app
This installs dependencies of all packages, the website, and all examples into the root node_modules folder. After an
npm install
, no furtherlerna bootstrap
is required.Internal dependencies within the repository now use
file:
paths. This way npm can do all of it by itself. When doing alerna publish
, lerna temporarily rewrites those to the actual version numbers.Note that when npm manages all dependencies, devDependencies of subpackages are not installed. This is because the subpackages like
@uppy/core
are themselves seen as dependencies by npm. dev dependencies need to be added to the root package.json instead. For the examples and the website, I've just moved everything to normaldependencies
.We now have a single
package-lock.json
containing all dependencies, so we can donpm ci
on travis to save some time.Best to make npm happy by removing all the
node_modules
folders first:The change list here is big because of all the lockfile changes. Almost every change to master will cause merge conflicts, but they are extremely easy to fix so we don't have to rush to get this in.