Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Plugin: made list items even out #1398

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Dashboard Plugin: made list items even out #1398

merged 1 commit into from
Apr 2, 2019

Conversation

lakesare
Copy link
Contributor

@lakesare lakesare commented Apr 1, 2019

___Why not just use justify-content: space-between?
Because making the last row items flock to the left side tends to be a trouble, solutions would be either not very browser-compatible, or would include some Js.

@arturi
Copy link
Contributor

arturi commented Apr 2, 2019

Love it! 💖 Thank you! Been looking for a good solution for quite some time, this nails it, I think.

  1. You introduced uppy-size--xl, that’s for inline: true and width: 1000 or something large like that, right?
  2. Should we set some max-width so there’s some sensible limit to the width of the files?

@arturi arturi self-requested a review April 2, 2019 09:08
@lakesare
Copy link
Contributor Author

lakesare commented Apr 2, 2019

  1. For >900pxs, yes.
  2. I played with max-width too, but we don't really need it (even on 100% on my mac they look good, and I imagine it's not a common use case to have the uppy dashboard span entire screen anyway), and any max-width will automatically make items not even.

@arturi arturi merged commit c8abe6f into transloadit:master Apr 2, 2019
@arturi
Copy link
Contributor

arturi commented Apr 2, 2019

All right, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants