-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues after #3444 merged #3473
Labels
Comments
@aduh95 didn’t we say we are using |
aduh95
added a commit
to aduh95/uppy
that referenced
this issue
Feb 9, 2022
I've opened #3475 to fix the docs, to me there should be only one |
aduh95
added a commit
that referenced
this issue
Feb 14, 2022
And use `pull_request_target` event instead of `pull_request` to use secrets from forks. Fixes: #3473 Co-authored-by: Mikael Finstad <[email protected]>
I have |
aduh95
added a commit
to aduh95/uppy
that referenced
this issue
Feb 17, 2022
Fixes: transloadit#3473 Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: Mikael Finstad <[email protected]>
aduh95
added a commit
that referenced
this issue
Feb 17, 2022
Fixes: #3473 Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: Mikael Finstad <[email protected]>
arturi
pushed a commit
that referenced
this issue
Feb 17, 2022
…mpanion tests (#3478) * fix broken npm run test * improve jest / companion add `npm run test:companion:watch` move env variables into code to make testing easier this allows for watching (source is causing problems with npm scripts) also now we can run `corepack yarn test:companion -t 'single test'` * fix root project jest make sure we don't run companion tests on npm run test:unit (as they don't work in a browser/jsdom environment) * improve validation logic previously incorrect options gives an Uploader object in an incorrect state * rewrite uploader to make it more testable * add test for xhr * check that metadata values are strings * fix nested meta causing error #3477 * convert meta to strings instead like the official FormData spec does * fix broken companion dev #3473 * fix botched merge * fix botched merge and remove --fix * fix botchedf merge * quick fix * . * remove eslint fix
vymao
pushed a commit
to vymao/uppy
that referenced
this issue
Mar 29, 2022
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this issue
Jun 27, 2023
…mpanion tests (transloadit#3478) * fix broken npm run test * improve jest / companion add `npm run test:companion:watch` move env variables into code to make testing easier this allows for watching (source is causing problems with npm scripts) also now we can run `corepack yarn test:companion -t 'single test'` * fix root project jest make sure we don't run companion tests on npm run test:unit (as they don't work in a browser/jsdom environment) * improve validation logic previously incorrect options gives an Uploader object in an incorrect state * rewrite uploader to make it more testable * add test for xhr * check that metadata values are strings * fix nested meta causing error transloadit#3477 * convert meta to strings instead like the official FormData spec does * fix broken companion dev transloadit#3473 * fix botched merge * fix botched merge and remove --fix * fix botchedf merge * quick fix * . * remove eslint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
npm run dev:with-companion
gives error in browser devtools console:env.sh
andenv.example.sh
, must rewrite to.env
.env
file must be placed inside/private/dev
https://github.com/transloadit/uppy/pull/3444/files/c1b929b1cf7d653fe04fc5f2180429ead2e230fe#diff-fc3164b27646d7e3e53c0cad07333439966a6b8835e85a4bc1c3f368944aba0a
The text was updated successfully, but these errors were encountered: