[Golden Retriever] Ability to clear upload history or set expiry date

[sakozz]

I have been testing Golden Retriever feature to restore files. I come to notice that it keeps history of all previous uploads. I was wondering if there is any proper way to clear the history or probably set some expiry date ?

[arturi]

Hi! Golden Retriever is in beta mode and history clearing / expiry date is on our todo. Likely coming to a next version of Uppy (or the one after it) close to you! PRs welcome :)

[goto-bus-stop]

#349 will help with this by clearing files that are no longer related to any file in localStorage.

Two ideas for things we could do now:

1. add a RestoreFiles.clear() method or something similar that removes all stored state and blobs for a given uppy instance ID, or for all instances, developers could use this manually, but I'm not sure how you would know when to clear
2. add a timestamp to the blobs in IndexedDB, and perhaps localStorage state, so we can automatically delete stored state and blobs that are past their expiry date when an uppy instance loads. We could do this for all uppy instance IDs whenever any instance loads. That way blobs from other instances that haven't been used for 24+ hours or so are also cleaned up, even if the user hasn't visited that page again. Maybe just maybe we could provide this as a separate utility module so that people could import it across their entire website, even on pages that don't use uppy.

There's an issue here about adding expiration to other storage forms, including indexeddb, which would be super nice: https://git.io/v5bau
But in the mean time the above would help a lot.

[arturi]

👍

3. We should also listen for upload-complete and delete the uploaded file, right?

[goto-bus-stop]

Yep although I think we want to keep the thumbnails of completed uploads

…

On 19 September 2017 00:39:11 CEST, Artur Paikin ***@***.***> wrote: 👍 3. We should also listen for `upload-complete` and delete the uploaded file, right? -- You are receiving this because you were assigned. Reply to this email directly or view it on GitHub: #324 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[arturi]

But then there’s no way to get rid of complete uploads? I think, maybe, once complete, it’s safe to not show it at all?

[goto-bus-stop]

Hmm yeah. I was thinking it'd make sense for thumbnails to keep showing if some of the files in a single upload() call succeeded, but others were still in progress.

we could address that more simply by listening for core:success instead though and delete all blobs for that upload instead of deleting the blobs individually.

[goto-bus-stop]

Expiry has landed in #369. Files will automatically be deleted after 24 hours by default. Blog post + docs for clearing manually, and setting a custom expiry timeframe, are coming up soon. Thanks!