Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #198

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Update dependencies #198

merged 2 commits into from
Oct 21, 2024

Conversation

remcohaszing
Copy link
Member

The only real upgrade is from form-data 3 to 4. All other updates either fit within the old semver range or are dev dependency updates.

The only real upgrade is from form-data 3 to 4. All other updates either
fit within the old semver range or are dev dependency updates.
@remcohaszing remcohaszing requested a review from mifi October 21, 2024 10:18
Some defaults were changed. Also the `.prettierignore` file is now
redundant. Prettier 3 respects `.gitignore`.
@mifi
Copy link
Collaborator

mifi commented Oct 21, 2024

lgtm but what are the breaking changes from form-data 3 to 4? I cannot seem to find the release notes. actually I've been wanting to move away from form-data entirely because it was long unmaintained and had many bugs, and there are much better alternatives now, see transloadit/uppy#3496

@remcohaszing
Copy link
Member Author

remcohaszing commented Oct 21, 2024

I would prefer to replace got and form-data with global fetch and FormData, which are now builtin to Node.js. However, that requires more effort I. I think we want to spend our time elsewhere currently.

I don’t really see anything breaking (https://github.com/form-data/form-data/releases/tag/v4.0.0).

@mifi
Copy link
Collaborator

mifi commented Oct 21, 2024

ok, maybe we can take the chance then with form-data 4

@remcohaszing remcohaszing merged commit b5dbb30 into main Oct 21, 2024
8 checks passed
@remcohaszing remcohaszing deleted the update-dependencies branch October 21, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants