Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to yarn 4 #171

Merged
merged 4 commits into from
Aug 19, 2024
Merged

upgrade to yarn 4 #171

merged 4 commits into from
Aug 19, 2024

Conversation

mifi
Copy link
Collaborator

@mifi mifi commented Nov 7, 2023

Note: breaking change (requires node>=18)

TODO

@mifi
Copy link
Collaborator Author

mifi commented Nov 8, 2023

I've tried to tinker with upgrading np to support yarn berry and it seems to be working, but I haven't done tests yet: mifi/np#1

@kvz
Copy link
Member

kvz commented Aug 2, 2024

upstream np accepts yarn 4 now as indicated in mifi/np#1, so we could likely upgrade np along with yarn and settle here

@mifi
Copy link
Collaborator Author

mifi commented Aug 4, 2024

yes but I think it would be a breaking change?

@kvz
Copy link
Member

kvz commented Aug 5, 2024

Only for contributors, not for consuming devs that added it as a dependency correct? Can’t they just npm/pnpm/yarn1 install this when it’s part of a project?

@remcohaszing
Copy link
Member

I’m running into the same problem in #176. Vitest also requires Node.js >=18. Although I personally prefer to test against all supported Node.js versions, I suggest we drop tests for Node.js 14 and 16 so we can upgrade Yarn and Vitest. The upcoming TypeScript migration will define a target matching Node.js 14, so the odds of breaking Node.js 14 support are slim.

@mifi
Copy link
Collaborator Author

mifi commented Aug 13, 2024

yea im fine with not testing against old versions for now

package.json Outdated Show resolved Hide resolved
Co-authored-by: Remco Haszing <[email protected]>
@kvz kvz merged commit cba2cb5 into main Aug 19, 2024
2 checks passed
@kvz kvz deleted the yarn4 branch August 19, 2024 08:56
remcohaszing added a commit that referenced this pull request Aug 19, 2024
remcohaszing pushed a commit that referenced this pull request Aug 19, 2024
remcohaszing added a commit that referenced this pull request Aug 19, 2024
Co-authored-by: Mikael Finstad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants