-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to yarn 4 #171
upgrade to yarn 4 #171
Conversation
I've tried to tinker with upgrading np to support yarn berry and it seems to be working, but I haven't done tests yet: mifi/np#1 |
upstream np accepts yarn 4 now as indicated in mifi/np#1, so we could likely upgrade np along with yarn and settle here |
yes but I think it would be a breaking change? |
Only for contributors, not for consuming devs that added it as a dependency correct? Can’t they just npm/pnpm/yarn1 install this when it’s part of a project? |
I’m running into the same problem in #176. Vitest also requires Node.js >=18. Although I personally prefer to test against all supported Node.js versions, I suggest we drop tests for Node.js 14 and 16 so we can upgrade Yarn and Vitest. The upcoming TypeScript migration will define a target matching Node.js 14, so the odds of breaking Node.js 14 support are slim. |
yea im fine with not testing against old versions for now |
Co-authored-by: Remco Haszing <[email protected]>
This reverts commit cba2cb5.
Co-authored-by: Mikael Finstad <[email protected]>
Note: breaking change (requires node>=18)
TODO