Assign nullable dtypes to dataframe columns #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinmatte
approved these changes
Apr 16, 2024
| @@ -58,12 +58,23 @@ def _local_save(s3_key, stop_events): | |||
| def _process_arrival_departure_times(pq_df: pd.DataFrame) -> pd.DataFrame: | |||
| """Process and collate arrivals and departures for a timetable of events. | |||
|
|
|||
| Before: TODO add example | |||
| After: TODO add example | |||
| This does two things: | |||
There was a problem hiding this comment.
Thanks so much for documenting everything 👏
|
Would be cool with this being merged as is and tests come in a second PR, but also fine to re-review later if you want to do tests in this same PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
A pr to fix:
#4
Even though parquet files have explicit per-column dtype metadata, pandas will overwrite these instructions for nullable integer columns and assign them as floats. Down the line, this causes overflow errors when numpy is trying to recast the epoch timestamps into datetimes.
More info: https://pandas.pydata.org/docs/user_guide/integer_na.html#nullable-integer-data-type
Tests to come.