Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreading and error catching #52

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Multithreading and error catching #52

merged 5 commits into from
Jan 17, 2024

Conversation

devinmatte
Copy link
Member

Multi-thread to reduce buffer size issues and catch any errors to avoid crashing and losing data

This may not fully fix the issue we ran into, but should make it less likely, and less impactful

  • For the degenerate events we don't need the trace info, we know why it's erroring, we can just log it
  • Update to latest on deps because we can

src/gobble.py Show resolved Hide resolved
Copy link
Contributor

@hamima-halim hamima-halim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gorge ✨

@devinmatte devinmatte merged commit 45198f3 into main Jan 17, 2024
4 checks passed
@devinmatte devinmatte deleted the catching-urllib-error branch January 17, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants