#477 Estimate tokens usage with streaming completions #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxmiron
commented
Mar 29, 2023
| export interface ChatMessage { | ||
| id: string | ||
| text: string | ||
| role: Role | ||
| name?: string | ||
| delta?: string | ||
| detail?: any | ||
| detail?: |
There was a problem hiding this comment.
It actually should not be nullable. In the current logic it can never be undefined in final message object. But I could not find a good way how to type it correctly with current mutation-like codestyle
There was a problem hiding this comment.
it's fine to leave it nullable for now. appreciate the note
transitive-bullshit
approved these changes
Apr 2, 2023
| @@ -59,13 +59,25 @@ export type SendMessageBrowserOptions = { | |||
| abortSignal?: AbortSignal | |||
| } | |||
|
|
|||
| interface CreateChatCompletionStreamResponse | |||
There was a problem hiding this comment.
i like to export all interfaces for ease of access by libs
| export interface ChatMessage { | ||
| id: string | ||
| text: string | ||
| role: Role | ||
| name?: string | ||
| delta?: string | ||
| detail?: any | ||
| detail?: |
There was a problem hiding this comment.
it's fine to leave it nullable for now. appreciate the note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #477
When making requests with
streammode (passingonProgress()) we don't have access to the tokensusageobjectAlternatively, we can calculate tokens
tiktoken- tokenized that, as they say, itself used in ChatGPT. Actually, cahtgpt-api is already doing it for calculating allowed length of message history sent to ChatGPT.So the only thing I've added:
ChatMessage.detailto safely read those fields in TS