Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 7.x #30

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Support Symfony 7.x #30

merged 1 commit into from
Jan 15, 2024

Conversation

curry684
Copy link
Contributor

@curry684 curry684 commented Dec 7, 2023

Quickfix, next should be to drop the complete requirement on symfony/cache and rely on interfaces.

@curry684
Copy link
Contributor Author

curry684 commented Dec 7, 2023

Feitelijk als je een "class_exists" toevoegt aan https://github.com/transip/transip-api-php/blob/master/src/TransipAPI.php#L144-L146 ben je er al om de hele afhankelijkheid van concrete implementatie optioneel te maken.

@curry684
Copy link
Contributor Author

curry684 commented Jan 5, 2024

Can this get merged?

@xvilo
Copy link
Member

xvilo commented Jan 5, 2024

Thanks for this PR @curry684, I'll take a closer look at this in the next week as the Symfony Bundle also needs an update 👍

@xvilo xvilo merged commit 13e0f24 into transip:master Jan 15, 2024
@curry684 curry684 deleted the symfony7 branch January 15, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants