This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Add calls #9
Closed
Add calls #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiallRees
commented
Oct 16, 2020
|
@NiallRees and @koszti (hey 👋) - please can we push this forward? Zenpy has merged Nialls upstream change (in 2.0.23). It may be good to upgrade to 2.0.24 to close the dependabot pr #13 at the same time 🙂🙏 |
|
Actually, this pr isn't quite ready 😅 I have an updated fork with this implementation here. @NiallRees (assuming this is no longer important to you) do you want to close this pr and I'll make another from the tails fork of your fork? |
Go for it. |
|
@kgpayne, sure if you send PR I'm happy to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on facetoe/zenpy#454