This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Thread more imports #187
Merged
Thread more imports #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`recreateChain` converts a list of notes into a forest of notes, using notes that are not replies as roots, and replies as child nodes, recursively. Previously, notes that are replies to notes not included in the export, and their children, were never put in the forest, and therefore wheren't imported. This can be fine when importing from Twitter, since we can't really link a note to a tweet. And, for the moment, it's acceptable when importing from *key, because the export doesn't contain the instance URL, so we can't resolve ids to remote notes. It's less fine when importing from Mastodon / Pleroma / Akkoma, because in those cases we _can_ link to the remote note that the user was replying to. This commit makes `recreateChain` optionally return "orphaned" note trees, so in the (near) future we can use it to properly thread imported notes from those services.
the id / replyId are not at the top level, so now `recreateChain` takes a list of keys to walk, not just a single key
I have _not_ tested this, but it should work fine, those exports are the same shape as Mastodon's
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I wrote in #177:
recreateChainconverts a list of notes into a forest of notes, using notes that are not replies as roots, and replies as child nodes, recursively.Previously, notes that are replies to notes not included in the export, and their children, were never put in the forest, and therefore wheren't imported.
This can be fine when importing from Twitter, or *key, since we can't really link a note to a tweet.
It's less fine when importing from Mastodon & Pleroma, because in those cases we can link to the remote note that the user was replying to.
This commit makes
recreateChainoptionally return "orphaned" note trees, and uses that feature when importing from Mastodon (tested) and Pleroma (should work fine).Checklist