Quick-and-dirty corner roundness toggle #124
Conversation
wont-work
force-pushed
the
corner-radius
branch
from
9839836 to
e3c36db
Compare
This reverts commit 7a51e2d.
This reverts commit e0fd136.
This reverts commit 9c8aaf3.
This reverts commit 8673435.
This reverts commit 74a07c3.
to keep things manageable i merged a lot of one off values into just a handful of common sizes, so some parts of the ui will look different than upstream even with the "Misskey" rounding mode
wont-work
force-pushed
the
corner-radius
branch
from
ec7b65a to
5ac1073
Compare
|
i haven't found any obvious breakages (beyond the avatar thing fixed in d4d2f6f) after running this for the last day or so, and the issues i had with locales not updating fixed itself after i rebased the pr on latest develop, un-drafting this pr |
Does this mean it also works fine with non-square avatars |
|
yep. that radius controls the avatar roundness, which gets set to 20% (edit: my local editor was on the develop branch, updated to correct value) with the .square class around line 189 (which gets applied by the square avatars setting) |
|
I see that some |
|
as far as i understand this is intended |
yep.
|
those are likely the upstream values carried over from the commit reverts. i'll prolly hardcode sharkey's radius values there in a bit. i think the stying on those pages are separate enough from the "main" misskey app that it shouldn't cause any issues either way and is just down to preference |
|
nvm i took too long to write that reply |
rip |
To keep things manageable I merged a lot of one off values into just a handful of common sizes, so some parts of the UI will look different than upstream even with the "Misskey" rounding mode.
A lot of find and replace were involved, so I definitely need another set of eyes to look over this and say what parts should be (un)rounded, marking as draft for now.